Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude locked collateral from available to withdraw. #121

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Dec 20, 2024

Screenshot 2024-12-20 at 7 13 06 PM Screenshot 2024-12-20 at 7 15 12 PM

@peiman3 peiman3 added the bug Something isn't working label Dec 20, 2024
@peiman3 peiman3 requested a review from noisekit December 20, 2024 13:00
@peiman3 peiman3 self-assigned this Dec 20, 2024
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:57pm

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.64%. Comparing base (cbdacd8) to head (ba18121).

Files with missing lines Patch % Lines
...y/lib/useAccountCollateral/useAccountCollateral.ts 90.90% 2 Missing ⚠️
...idity/ui/src/components/Manage/CollateralStats.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   66.51%   66.64%   +0.12%     
==========================================
  Files         262      263       +1     
  Lines        6418     6451      +33     
  Branches     2083     2089       +6     
==========================================
+ Hits         4269     4299      +30     
- Misses       2149     2152       +3     
Files with missing lines Coverage Δ
...idity/ui/src/components/Positions/PositionsRow.tsx 57.44% <100.00%> (+0.92%) ⬆️
liquidity/ui/src/components/Withdraw/Withdraw.tsx 98.07% <100.00%> (+0.20%) ⬆️
...idity/ui/src/components/Manage/CollateralStats.tsx 90.47% <80.00%> (-3.28%) ⬇️
...y/lib/useAccountCollateral/useAccountCollateral.ts 90.90% <90.90%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants