Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show "Unlock" and "Withdraw" buttons when relevant to user. #119

Closed
wants to merge 2 commits into from

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Dec 19, 2024

No description provided.

@peiman3 peiman3 added the enhancement New feature or request label Dec 19, 2024
@peiman3 peiman3 requested a review from noisekit December 19, 2024 13:40
@peiman3 peiman3 self-assigned this Dec 19, 2024
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:26am

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.59%. Comparing base (cbdacd8) to head (eb9eb9d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   66.51%   66.59%   +0.07%     
==========================================
  Files         262      262              
  Lines        6418     6430      +12     
  Branches     2083     2088       +5     
==========================================
+ Hits         4269     4282      +13     
+ Misses       2149     2148       -1     
Files with missing lines Coverage Δ
...quidity/ui/src/components/Manage/ManageActions.tsx 53.98% <100.00%> (+0.82%) ⬆️
liquidity/ui/src/components/Manage/actions.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@noisekit
Copy link
Contributor

We have decided to always show all actions so this task is no longer relevant.
And full redesign is incoming as well.

@noisekit noisekit closed this Dec 22, 2024
@noisekit noisekit deleted the manage-actions branch December 22, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants