Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers - Add sqlfluff workflow #93

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Conversation

marcus-snx
Copy link
Collaborator

@marcus-snx marcus-snx commented Aug 7, 2024

Add sqlfluff linting workflow (only for new changes using diff-quality).

@Tburm
Copy link
Collaborator

Tburm commented Aug 8, 2024

Is there any benefit to doing a one-time lint on the existing files? Did you test this? The workflow looks good but I'm wondering how many changes this would make.

@marcus-snx
Copy link
Collaborator Author

Is there any benefit to doing a one-time lint on the existing files? Did you test this? The workflow looks good but I'm wondering how many changes this would make.

Linting everything at once is possible (and there are good reasons for both doing it and not) with sqlfluff fix, but if we want to do it maybe it should be in a separate PR (I've had some troubles with fixing lint errors in the past on dbt projects). This workflow only adds a lint test (won't lint things automatically) for new and/or modified lines, not existing ones.

@Tburm Tburm merged commit 546bc18 into main Aug 9, 2024
2 checks passed
@Tburm Tburm deleted the transformers/add-sqlfluff branch August 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants