Skip to content

Commit

Permalink
Update sccp-308.md
Browse files Browse the repository at this point in the history
  • Loading branch information
kaleb-keny committed Sep 29, 2023
1 parent 3063e68 commit 3b70d89
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions content/sccp/sccp-308.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@ This SCCP proposes to incorporate a stalenss check on the chainlink node used fo

<!--A short (~200 word) description of the variable change proposed.-->

The chainlink node would have a staleness check incoporated based on the chainlink [heartbeat](https://docs.chain.link/data-feeds/price-feeds/addresses?network=ethereum&page=1&search=snx) of the respective network. The configuration would be 129,600 seconds (1.5 days) on ethereum and 3,600 seconds on optimism.

Note that the proposed changes herein are currently proposed under SCCPs, since with respect to v3 oracles restrictions and filters on existing oracles can be performed via configuration changes, further reference can be found [here](https://github.com/Synthetixio/synthetix-v3/tree/main/protocol/oracle-manager).
The chainlink node would have a staleness check incoporated based on the chainlink [heartbeat](https://docs.chain.link/data-feeds/price-feeds/addresses?network=ethereum&page=1&search=snx) of the respective network. The configuration would be 5,400 seconds on ethereum and 2,400 seconds on optimism.

Note that with respect to v3 oracles, restrictions and filters on existing oracles (such as the chainlink oracle), could be performed via configuration changes, further reference can be found [here](https://github.com/Synthetixio/synthetix-v3/tree/main/protocol/oracle-manager).

## Motivation

<!--The motivation is critical for SCCPs that want to update variables within Synthetix. It should clearly explain why the existing variable is not incentive aligned. SCCP submissions without sufficient motivation may be rejected outright.-->

Currently the configured chainlink node does not incorporate any stalenss check. However, it is considered best practice that prices are checked for staleness before being consumed in staking, unstaking and liquidation. Hence, in case the oracle is stale, all activity that touches the oracle would revert (e.g. staking, unstaking and liquidations).
Currently the configured chainlink node does not incorporate any stalenss check. However, it is considered best practice that prices are checked for staleness before being consumed (e.g. staking, unstaking and liquidation). Hence, in case the oracle is stale, all activity that touches the oracle would revert.


## Copyright
Expand Down

0 comments on commit 3b70d89

Please sign in to comment.