Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository class definition #877

Draft
wants to merge 2 commits into
base: 1.11
Choose a base branch
from
Draft

Fix repository class definition #877

wants to merge 2 commits into from

Conversation

loic425
Copy link
Member

@loic425 loic425 commented May 17, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner May 17, 2024 13:43
@loic425 loic425 marked this pull request as draft May 17, 2024 13:43
loic425
loic425 commented May 17, 2024
View reviewed changes
tests/Bundle/Resource/ResourceServicesTest.php
@@ -79,6 +79,6 @@ public function it_will_return_the_same_repository_instance_for_default_reposito
$repositoryAlias = $em->getRepository(ComicBook::class);

$this->assertInstanceOf(RepositoryInterface::class, $repository);
$this->assertSame($repository, $repositoryAlias);
$this->assertSame($repository::class, $repositoryAlias::class);
Copy link
Member Author

@loic425 loic425 May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suspicious...
Why the instance is different...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loic425