-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Component namespace on Doctrine #761
Merged
lchrusciel
merged 5 commits into
Sylius:1.11
from
loic425:move-component-namespace/doctrine
Oct 27, 2023
Merged
Remove Component namespace on Doctrine #761
lchrusciel
merged 5 commits into
Sylius:1.11
from
loic425:move-component-namespace/doctrine
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Oct 23, 2023
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | |
License | MIT |
loic425
force-pushed
the
move-component-namespace/doctrine
branch
from
October 23, 2023 12:38
9f618f6
to
2b3615d
Compare
loic425
force-pushed
the
move-component-namespace/doctrine
branch
from
October 25, 2023 08:00
1ff4871
to
935c561
Compare
@diimpp theses classes were introduced in 1.11 alpha too |
Prometee
approved these changes
Oct 25, 2023
oallain
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM 👍
diimpp
approved these changes
Oct 25, 2023
diimpp
approved these changes
Oct 25, 2023
lchrusciel
approved these changes
Oct 27, 2023
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.