Use AsResource attribute instead of reserved word Resource #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
feature/use-as-resource-attribute-instead-of-resource
branch
from
cc994cf
to
3449806
Compare
loic425
changed the title
loic425
deleted the
feature/use-as-resource-attribute-instead-of-resource
branch
loic425
restored the
feature/use-as-resource-attribute-instead-of-resource
branch
loic425
deleted the
feature/use-as-resource-attribute-instead-of-resource
branch
loic425
restored the
feature/use-as-resource-attribute-instead-of-resource
branch
loic425
deleted the
feature/use-as-resource-attribute-instead-of-resource
branch
loic425
restored the
feature/use-as-resource-attribute-instead-of-resource
branch
lchrusciel
approved these changes
Oct 23, 2023
|
Thank you, @loic425! |
loic425
deleted the
feature/use-as-resource-attribute-instead-of-resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resourceis a reserved word as Soyuka warned me on API CON.So I think it will be better to use AsResource attribute instead.
if needed I can add an old Resource attribute with class_alias if we do not want to break users using alpha version.
Or maybe just add a note on the UPGRADE.md
I use a ResourceMetadata (old Resource one) object cause I don't want to make a
new AsResource()call which is uggly.