Add platform.sh support #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senghe
force-pushed
the
feature/platform-sh-support
branch
from
1b31a3f to
db6201f
Compare
TheMilek
force-pushed
the
feature/platform-sh-support
branch
from
925f284 to
0065622
Compare
TheMilek
force-pushed
the
feature/platform-sh-support
branch
from
0065622 to
883f9eb
Compare
diimpp
previously requested changes
Apr 22, 2024
.platform.app.yaml
Outdated
| @@ -0,0 +1,99 @@ | |||
| name: sylius | |||
|
|
|||
| type: php:8.1 | |||
There was a problem hiding this comment.
Build flavor should be specified at the top.
Suggested change
| type: php:8.1 | |
| type: php:8.1 | |
| build: | |
| flavor: none |
There was a problem hiding this comment.
Overall placement feels weird, I personally would go for
- type
- build
- runtime
- variables
- dependencies
- hooks
- relationships
- disk
- mounts
- web
- workers
- cron
or last three as
- workers
- cron
- web
There was a problem hiding this comment.
I will leave it for now as it is similar to config provided for the template by platform.sh 🤔 https://github.com/platformsh-templates/sylius/blob/master/.platform.app.yaml
TheMilek
force-pushed
the
feature/platform-sh-support
branch
3 times, most recently
from
31b16b3 to
aac747b
Compare
TheMilek
force-pushed
the
feature/platform-sh-support
branch
from
aac747b to
cf624b9
Compare
mpysiak
approved these changes
May 10, 2024
GSadee
approved these changes
May 13, 2024
|
Thank you, Marcin! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I've already prepared a platform.sh setup configuration for Sylius. In a nearest future I'll push also a documentation for this feature into Sylius repository.
I hope you like it 🖖