Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Parameters to another file #941

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Move Parameters to another file #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1abf794
Move Parameters to another file
TheMilek Jan 22, 2024
bcbe2e5
Exclude Symfony 6 build with php 8.0
TheMilek Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ jobs:
symfony: ["^5.4", "^6.0"]
node: ["16.x"]
mysql: ["5.7", "8.0"]
exclude:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit related to REF

-
php: "8.0"
symfony: "^6.0"

env:
APP_ENV: test_cached
Expand Down
1 change: 1 addition & 0 deletions config/packages/_sylius.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ imports:

- { resource: "@SyliusShopBundle/Resources/config/app/config.yml" }
- { resource: "@SyliusPayPalPlugin/Resources/config/config.yaml" }
- { resource: "../parameters.yaml" }

parameters:
sylius_core.public_dir: '%kernel.project_dir%/public'
Expand Down
2 changes: 2 additions & 0 deletions config/parameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
parameters:
locale: en_US
5 changes: 0 additions & 5 deletions config/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
# Put parameters here that don't need to change on each machine where the app is deployed
# https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
parameters:
locale: en_US

services:
# Default configuration for services in *this* file
_defaults:
Expand Down
Loading