-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Docker concept #935
Conversation
5420ff2
to
8c62b61
Compare
231c23f
to
a81b46f
Compare
a81b46f
to
c8e8f9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO there's a lot of things happening in the compose files. Maybe we could introduce some "abstraction" by using custom Dockerfiles. For example, my compose files I'm using are +/- like this:
services:
php:
extends:
file: /Users/jacob/Docker/compose/php.yaml
service: frankenphp
env_file:
- .env.local
environment:
APP_URL: sylius.orb.local
labels:
- dev.orbstack.domains=sylius.orb.local
volumes:
- app:/app:delegated
depends_on:
- db
db:
extends:
file: /Users/jacob/Docker/compose/database.yaml
service: mariadb
volumes:
- database:/var/lib/mysql
labels:
- dev.orbstack.domains=db-sylius.orb.local
frontend:
extends:
file: /Users/jacob/Docker/compose/common.yaml
service: node
volumes:
- app:/app
mailhog:
image: mailhog/mailhog
labels:
- dev.orbstack.domains=mailhog-sylius.orb.local
Some things are due to the fact I'm using the Orbstack, but we should definitely consider making the Docker experience as simple as we can.
From our experience, not every person touching Sylius with Docker is familiar with it.
version: "3.8" | ||
services: | ||
php: | ||
image: ghcr.io/sylius/sylius-php:8.2-fixuid-xdebug-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an exterior image requires some customisation documentation
It's my own opinion but I'm not fan of the external tool dependency (fixuid) which isn't even 1.0 released. |
fixuid is reasonable way for DX development to handle correct UIDs and GIDs for Linux/Windows(WSL); for Mac it is redundant. |
The new concept allows to setup environment with just one command 🚀
Requirements
used dependencies