Skip to content

Commit

Permalink
Added the 'srcrad' parameter to spectra and lc requests, updated all …
Browse files Browse the repository at this point in the history
…API versions ready for a new release (#20)
  • Loading branch information
DrPhilEvans authored May 29, 2024
1 parent 81fa93f commit 48da0e1
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 21 deletions.
14 changes: 7 additions & 7 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = swifttools
version = 3.0.21
name = swifttools
version = 3.0.22
description = Tools for users of the Swift satellite
long_description = file: README.md
long_description_content_type = text/markdown
Expand All @@ -26,11 +26,11 @@ packages = find:
platforms = any
include_package_data = True
python_requires = >= 3.6
install_requires =
requests
python-jose
pandas
tabulate
install_requires =
requests
python-jose
pandas
tabulate
numpy
boto3
[bdist_wheel]
Expand Down
4 changes: 3 additions & 1 deletion swifttools/ukssdc/APIDocs/ukssdc/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

Changes made to this module after its original release will be documented here.

* 2024 May 29: v1.0.5 released as part of `swifttools` v3.0.22
* `swifttools.ukssdc.xrt_prods` v1.12 released: adds a `srcrad` parameter for light curves and spectra.
* 2023 May 24: Modification to the back end, light curve `dict` now includes an "Exposure" column in the hard/soft/ratio datasets.
* 2022 September 06. v1.0.3 relased as part of `swifttools` v3.0.5
* Further minor bugfixes in `mergeUpperLimits()`.
* Fixed an issue only affecting Python >=3.9: the `math.factorial()` function now requires the argument
to be an integer, it does not accept floats such as "3.0". This caused en error in `bayesRate()` as called
by `mergeUpperLimits()` and `mergeLightCurveBins()`.
* 2022 September 01. v1.0.2 relased as part of `swifttools` v3.0.2
* Minor bugfixes in `mergeUpperLimits()`
* Minor bugfixes in `mergeUpperLimits()`
4 changes: 4 additions & 0 deletions swifttools/ukssdc/APIDocs/ukssdc/xrt_prods/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Changes made to this module after its original release will be documented here.

* 2024 May 29: xrt_prods v1.12 with `swifttools` v3.0.22
* This release adds a new `srcrad` parameter to light curves and spectra, which sets the maximum size the source
radius can extend to. This is only useful for rare, exteremly piled up sources where the annulus to exclude
needs to be larger than the default 30-pixel maximum radius.
* 2022 August 31. xrt_prods v1.10 released, with swifttools 3.0.
* This release contains many changes **including deprecating some old behaviour**. Full details
are given in the [release notes](ReleaseNotes_v110.md).
Expand Down
19 changes: 11 additions & 8 deletions swifttools/ukssdc/APIDocs/ukssdc/xrt_prods/RequestJob.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
The main part of requesting products be built is, well, requesting that products be built(!). This is relatively
straightforward in concept and can be done with a very small number of commands; however, it does require you to know
what parameters can be set, and which ones are mandatory. Fortunately, this page gives you all of that information.
**Note**: This documentation is not designed to introduce the XRT Product Generator. If you are not familiar with this
**Note**: This documentation is not designed to introduce the XRT Product Generator. If you are not familiar with this
facility we strongly advise you to read [that facility's documentation](https://www.swift.ac.uk/user_objects/docs.php) first, and we also recommend
that you build a few products via [the web interface](https://www.swift.ac.uk/user_objects/) web interface to familiarise yourself
with the system before trying to use the Python module.
Expand Down Expand Up @@ -68,8 +68,8 @@ Out[5]: None
In [6]: myReq.getGlobalPars() # same as getGlobalPars('all')
Out[6]: {'centroid': True, 'posErr': 1.5}

In [7]: myReq.getGlobalPars(showUnset=True)
Out[7]:
In [7]: myReq.getGlobalPars(showUnset=True)
Out[7]:
{'name': None,
'targ': None,
'T0': None,
Expand Down Expand Up @@ -208,7 +208,7 @@ The following problems were found:
* Global parameter `targ` is not set, and nor is the alternative: `getTargs`.
```

Ah, yes, that would explain it. I forgot to set a bunch of parameters. In this particular case the request submission failed before python even tried to submit it to the server, because some internal checks are done before submission. You can do these checks yourself before running `submit()` if you want, via the `isValid()` function. This takes one (optional) argument, which is either 'all' (the default) or a list/tuple of products to check. It returns a list with two entries: first a `bool` indicating whether the product/request is valid or not, and second a text string saying what's wrong (if it's not ready).
Ah, yes, that would explain it. I forgot to set a bunch of parameters. In this particular case the request submission failed before python even tried to submit it to the server, because some internal checks are done before submission. You can do these checks yourself before running `submit()` if you want, via the `isValid()` function. This takes one (optional) argument, which is either 'all' (the default) or a list/tuple of products to check. It returns a list with two entries: first a `bool` indicating whether the product/request is valid or not, and second a text string saying what's wrong (if it's not ready).

```python
In [18]: status = myReq.isValid( ['LightCurve', 'Spectrum'])
Expand Down Expand Up @@ -252,7 +252,7 @@ spectrum problems:
When you submit a request, you don't have to supply every possible parameter, many of them have default values. And some parameters ask the server to calculate
other values: for example if `getCoords` is `True` then the server will try to resolve the supplied name, to get the position. You may want to know what values the server actually used, either for sanity checking (is the resolved position what you were expecting?) or so that you can submit a later job with the same set of parameters.

Of course, you can find this out by looking at [the data returned by the server](ReturnData.md), but you then have to manage those data yourself. On the other hand, as discussed in [Advanced usage](advanced.md), we provide a simple mechanism to dump the parameters and values from one request and paste them into another: this is useful if you want to create a similar / identical request (for example, to update a product every time it is re-observed, without changing any of the parameters). For this case, it is helpful to have your request parameters updated to include those set by the server, so that if you dump or copy those parameters you know that you are copying the exact parameters. Since changing the product parameters after submission has no effect on the running jobs (and indeed, you can't manually change parameters after submission), this option is `True` by default, For more infomration see [Advanced usage](advanced.md).
Of course, you can find this out by looking at [the data returned by the server](ReturnData.md), but you then have to manage those data yourself. On the other hand, as discussed in [Advanced usage](advanced.md), we provide a simple mechanism to dump the parameters and values from one request and paste them into another: this is useful if you want to create a similar / identical request (for example, to update a product every time it is re-observed, without changing any of the parameters). For this case, it is helpful to have your request parameters updated to include those set by the server, so that if you dump or copy those parameters you know that you are copying the exact parameters. Since changing the product parameters after submission has no effect on the running jobs (and indeed, you can't manually change parameters after submission), this option is `True` by default, For more infomration see [Advanced usage](advanced.md).

---

Expand All @@ -272,7 +272,7 @@ parameters are not tied to any specific product but affect all products.
The product-specific parameters are, as the name implies, tied to
specific parameters.

Most fields are self-explanatory. Times can be entered in any of the [formats specified in the XRT Products documentation](https://www.swift.ac.uk/user_objects/docs.php#timeformat). the `useObs` fields can contain either a list of Swift obsIDs, or a comma-separated list of *start-stop* values, where start/stop are times in the formats just described.
Most fields are self-explanatory. Times can be entered in any of the [formats specified in the XRT Products documentation](https://www.swift.ac.uk/user_objects/docs.php#timeformat). the `useObs` fields can contain either a list of Swift obsIDs, or a comma-separated list of *start-stop* values, where start/stop are times in the formats just described.

---

Expand Down Expand Up @@ -373,6 +373,8 @@ Some of the light curve parameters are relevant for all binning methods, some on
| timeFormat | No | str | The units to use on the time axis. Must be one of {'s'(=seconds), 'm'(=MJD)} | 's' |
| whichData | No | str | Which observations to use for the light curve. Must be one of {'all', 'user'} | 'all' |
| useObs | If `whichData='user'` | str | The specific observations to use to create the light curve [[Details](https://www.swift.ac.uk/user_objects/docs.php#useobs)] | -- |
| srcrad | No | int | The maximum radius the source extraction region can be (pixels). | -- |




Expand Down Expand Up @@ -432,9 +434,10 @@ Some parameters are relevant all the time, some are only needed if you are defin
| galactic | No | bool | Whether to include an absorber fixed at the Galactic value, as well as a free absorber. | False |
| models | No | list/tuple | A list of emission models to fit (options are 'apec', 'powerlaw' and 'blackbody'). | ('powerlaw') |
| deltaFitStat | No | float | The change in fit statistic used to calculate the parameter errors on the spectral fit. | 2.706 |
| srcrad | No | int | The maximum radius the source extraction region can be (pixels). | -- |

The last 3 parameters were newly introduced in v1.10 of the module (part of `swifttools` v3.0) and represent
functionality recently added to the service and also available via the website. If `galactic` is `True`, the value
functionality recently added to the service and also available via the website. If `galactic` is `True`, the value
of the Galactic component is taken from [Willingale et al., (2013)](https://ui.adsabs.harvard.edu/abs/2013MNRAS.431..394W/abstract).
The `models` parameter is case-insensitive and if it contains multiple elements then multiple models will be fitted.
**Note** Specifying multiple models will give separate fits with the different emisssion models. i.e. If you supply
Expand Down Expand Up @@ -492,7 +495,7 @@ The following parameters can be set for creating an image.

| Parameter | Mandatory? | Type | Description | Default |
| :---- | :----: | :---: | :----- | :----: |
| energies | No | str | A string comprising a comma-separated list of energy bands for your images. | '0.3-10,0.3-1.5,1.51-10' |
| energies | No | str | A string comprising a comma-separated list of energy bands for your images. | '0.3-10,0.3-1.5,1.51-10' |
| whichData | No | str | Which datasets to use in the image. Must be one of {'all', 'user'} | 'all' |
| useObs | If `whichData='user'` | str | The specific observations to use to create the image [[Details](https://www.swift.ac.uk/user_objects/docs.php#useobs)] | -- |

Expand Down
4 changes: 2 additions & 2 deletions swifttools/ukssdc/version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__version__ = "1.0.4"
_apiVersion = "1.0.4"
__version__ = "1.0.5"
_apiVersion = "1.0.5"
2 changes: 2 additions & 0 deletions swifttools/ukssdc/xrt_prods/productVars.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@
"pcHRBinTime": (float, int),
"minFracExp": (float, int),
"whichData": (str,),
"srcrad": (int,),
},
"spec": {
"hasRedshift": (bool,),
Expand All @@ -196,6 +197,7 @@
"galactic": (bool,),
"models": (list, tuple),
"deltaFitStat": (float,),
"srcrad": (int,),
},
"psf": {},
"enh": {},
Expand Down
4 changes: 2 additions & 2 deletions swifttools/ukssdc/xrt_prods/version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__version__ = "1.11"
_apiVersion = "1.11"
__version__ = "1.12"
_apiVersion = "1.12"
2 changes: 1 addition & 1 deletion swifttools/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "3.0.21"
__version__ = "3.0.22"

0 comments on commit 48da0e1

Please sign in to comment.