-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/lp zapping #1596
Open
karczuRF
wants to merge
61
commits into
develop
Choose a base branch
from
feat/lp-zapping
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/lp zapping #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/lp-zapping
…e pathname for zap and swap
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
August 26, 2023 10:19
fb69230
to
0c5053c
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
November 7, 2023 14:07
ff47650
to
b3b3815
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
March 7, 2024 11:08
91e4f23
to
af06da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #491
Beta version of LP-Zapping feature!
LP-Zapping allows to swap any erc-20 token (but native currency is also supported!) for 2 different tokens and add liquidity to the pool with just 1-click!
It works also in another direction, so allows to remove liquidity from the pool and swap pool's tokens to any different token, ofc also with 1-click.
Important node
Since this is quite complex feature there still can be bugs which I couldn't find, so keep in mind this is still Beta version!
Designs still needs to be created (eg zap details, slippage etc) and will be added as soon as we have them.
The latest version of zap contract can be found here: https://github.com/ImpeccableHQ/swapr-lp-zapping/blob/main/contracts/Zap.sol
Test Zap contract was deployed on Gnosis only, so for any other network zap is not yet available!
Contract details can be found here: https://blockscout.com/xdai/mainnet/address/0x618471C54443586E97FD81cDc357DCB9a1db8f87
To Test