Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Added config and services tests #75

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Added config and services tests #75

wants to merge 8 commits into from

Conversation

Du-z
Copy link
Collaborator

@Du-z Du-z commented Oct 1, 2022

Added some more config tests.

The failing tests are setup so that ConfigBuilder.Build() builds from the parent ConfigBuilder.Basic rather than the child ConfigBuilder.UseRpc.

This is ultimately the same way that the Service is built also. Their tests fail for the same reason.

I'm not quite sure what the correct fix for this is.

@ProphetLamb
Copy link
Collaborator

I merged the commit that continues the building even if the nightly fails

@ProphetLamb
Copy link
Collaborator

The behaviour is actually intended, so that we can have a shared configuration, and multiple branching configurations.
I could change this behaviour, by collecting a list, but I am unsure whether this is desireable. I know that ASP.NET does it that way

@Du-z
Copy link
Collaborator Author

Du-z commented Oct 3, 2022

I don't think we want this behavior. The services tests fail to get parts of their configuration built because of this.

Collecting a list sounds like it would give us a lot more flexibility

@ProphetLamb ProphetLamb changed the base branch from master to develop October 9, 2022 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants