test coverage for setValidatorInactivityThreshold()

SurfingNerd · Dec 3, 2023 · 95b045b · 95b045b
1 parent f79f9c1
commit 95b045b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/contracts/ValidatorSetHbbft.sol b/contracts/ValidatorSetHbbft.sol
@@ -280,7 +280,7 @@ contract ValidatorSetHbbft is Initializable, OwnableUpgradeable, IValidatorSetHb
         // if you want smaller values for tests,
         // the contract can be deployed with a smaller value
         // (no restriction there)
-        require(_seconds > 604800);
+        require(_seconds > 604800, "_seconds value must be less then a week.");
         validatorInactivityThreshold = _seconds;
     }
 

diff --git a/test/ValidatorSetHbbft.ts b/test/ValidatorSetHbbft.ts
@@ -1222,6 +1222,30 @@ describe('ValidatorSetHbbft', () => {
             }
         });
     });
+
+    describe('setValidatorInactivityThreshold()', async() => {
+        it('fail on small value', async () => { 
+            const { validatorSetHbbft } = await helpers.loadFixture(deployContractsFixture);
+
+            await expect(validatorSetHbbft.setValidatorInactivityThreshold(100)).to.be.revertedWith("_seconds value must be less then a week.");
+
+        }); 
+
+        it('correct value is set', async () => { 
+            const { validatorSetHbbft } = await helpers.loadFixture(deployContractsFixture);
+
+            let value30Days = 2592000; 
+            await validatorSetHbbft.setValidatorInactivityThreshold(value30Days); 
+            expect(await validatorSetHbbft.validatorInactivityThreshold()).to.be.equal(value30Days);
+        }); 
+
+        it('only owner should be able to change value', async () => { 
+            const { validatorSetHbbft } = await helpers.loadFixture(deployContractsFixture);
+            let nobody =  (await ethers.getSigners())[42];
+            let value30Days = 2592000; 
+            await expect(validatorSetHbbft.connect(nobody).setValidatorInactivityThreshold(value30Days)).to.be.revertedWith("Ownable: caller is not the owner");
+        });
+    });
 });
 
 function convertToBigEndian(number: number): number[] {