Configurable translatable fields #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2021 16:38
Previously, translatable fields were hard-coded in the various decorators. With this change, they can be overridden with configuration in the client application using similar configuration patterns to other solidus extensions.
harmonymjb
requested review from
sofiabesenski4,
benjaminwil and
jarednorman
benjaminwil
approved these changes
Sep 28, 2021
jarednorman
approved these changes
Sep 28, 2021
This was blocking support for Ruby 3.0 in this extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change allows application configuration of translatable fields on Spree models decorated with globalize.
I've tested this in our client app as follows, which removes
:namefrom translatable fields forSpree::OptionValue.I was unable to bundle and test this repo, as there are dependency version issues.
P.S.
Not sure of where would be the best place to PR this as we use a non-main branch (
kennyadsl/solidus-3)