Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test configuration and update scraper #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test configuration and update scraper #3

wants to merge 2 commits into from

Conversation

kaminyv
Copy link

@kaminyv kaminyv commented Apr 23, 2024

Configuration testing has been performed and the scraper has been updated for efficient data acquisition.

@Lekki369
Copy link
Collaborator

@kaminyv fix your merge conflicts

Lekki369
Lekki369 requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@Lekki369 Lekki369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIX YOUR MERGE CONFLICTS

@kaminyv
Copy link
Author

kaminyv commented Apr 29, 2024

@Lekki369 I do not have permission to resolve these conflicts.

@Lekki369
Copy link
Collaborator

@kaminyv

  1. did the creator of this codebase request for the changes you are trying to modify?
  2. If so, why are you trying to merge into main from your forked version to the repo? If you need to make any changes, let the creator add you as a collaborator so you can create a branch for your changes and push that branch to the repo against the main branch.

Regards,
Lekki

@kaminyv kaminyv force-pushed the main branch 2 times, most recently from 0dc5718 to 38899ee Compare May 1, 2024 12:23
@kaminyv
Copy link
Author

kaminyv commented May 1, 2024

@Lekki369

  1. Yes, these changes are in addition to the work done.
  2. You can finish this code review, conflicts shouldn't bother us anymore.

Lekki369
Lekki369 reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@Lekki369 Lekki369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will go through it

Lekki369
Lekki369 reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@Lekki369 Lekki369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Commented out this!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lekki369 Lekki369 Lekki369 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaminyv @Lekki369