Leave the service disabled after the collector resource's :install action #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
No.
General
Remove any versioning you did yourself if applicable
Update Changelog following the conventions laid out on Keep A Changelog with all new changes under
## [Unreleased]
and using a### Added, Fixed, Changed, or Breaking Change
sub-header.Update README with any necessary changes
RuboCop passes
Foodcritic passes
Existing tests pass
Purpose
The installer script, even if it's run with
-VskipRegistration=true
, enablesthe service. This means the collector resource's
:install
action leavesbehind an unconfigured collector that will nonetheless try (and fail) to start
at boot time.
I can see the argument that this is the install script's default behavior, so
this is the state it should be left in. But it was a small enough change I
wanted to submit it and see what folks think.