Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave the service disabled after the collector resource's :install action #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hartmantis
Copy link
Contributor

Pull Request Checklist

Is this in reference to an existing issue?

No.

General

  • Remove any versioning you did yourself if applicable

  • Update Changelog following the conventions laid out on Keep A Changelog with all new changes under ## [Unreleased] and using a ### Added, Fixed, Changed, or Breaking Change sub-header.

  • Update README with any necessary changes

  • RuboCop passes

  • Foodcritic passes

  • Existing tests pass

Purpose

The installer script, even if it's run with -VskipRegistration=true, enables
the service. This means the collector resource's :install action leaves
behind an unconfigured collector that will nonetheless try (and fail) to start
at boot time.

I can see the argument that this is the install script's default behavior, so
this is the state it should be left in. But it was a small enough change I
wanted to submit it and see what folks think.

…tion

The installer script, even if it's run with `-VskipRegistration=true`, enables
the service. This means the collector resource's `:install` action leaves
behind an unconfigured collector that will nonetheless try (and fail) to start
at boot time.

I can see the argument that this is the install script's default behavior, so
this is the state it should be left in. But it was a small enough change I
wanted to submit it and see what folks think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant