Update artifact upload workflow #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the NuGet restore and build steps to use 'Plugins.Filter.slnf' instead of 'Plugins.sln'. This ensures only the relevant projects are included in the build process, optimizing the workflow. Update Visual Studio version in solution file Changed the Visual Studio version to 17.12 in the Plugins.sln file. This update ensures compatibility with the latest Visual Studio features and improvements. Update UnitTests project GUID and adjust solution configuration Changed the GUID for the UnitTests project to ensure consistency and proper reference within the solution. Additionally, updated solution configurations to reflect the new GUID and added a GlobalSection for Shared MSBuild project files. Remove Debug configurations for Project B6BEFF Eliminated redundant Debug configurations for project B6BEFF13-3DDF-87D9-C875-312EA5AA33DB from Plugins.sln. This helps in maintaining a cleaner solution file and avoids unnecessary build configurations. Update project configurations for Plugins.sln and Plugins.slnx Added missing build configuration in Plugins.sln for a project, ensuring it builds correctly in Debug mode. Removed unnecessary configuration tags from Plugin-Shared.shproj in Plugins.slnx, simplifying the project file structure. Update NuGet restore target in workflow Changed the NuGet restore command to reference "source\Plugins.sln" instead of "source\Plugins.Filter.slnf" in the GitHub Actions workflow. This likely corrects the target solution file for package restoration. Update build solution path in GitHub Actions workflow Changed the msbuild command to point to "source/Plugins.sln" instead of "source/Plugins.Filter.slnf". This ensures the correct solution file is used during the build process in the workflow. Remove redundant Debug build configuration entry This change deletes an unnecessary Debug build configuration entry from the solution file. The removal helps to streamline the solution configurations, potentially reducing build times and simplifying maintenance. Configure build output paths for Plugin-Shared project Added conditional property groups to specify output paths for Debug and Release configurations in the Plugin-Shared shared project. Updated the solution file to explicitly define the configuration for the Plugin-Shared project. Update project GUIDs and add missing projects Updated the GUIDs for several projects to correct issues with project references. Also, added the missing "UnitTests" and "WordSpellCheck" projects, and included the "github-workflows" section for improved project organization. Remove unused workflow and simplify artifact uploads Deleted `upload-artifacts.yml` and removed its reference from the solution file. Simplified artifact uploads in `main.yml` by explicitly listing each plugin without using a matrix strategy. This streamlines the build process and reduces complexity. Remove SkipSharedProject flag from msbuild command This change updates the GitHub Actions workflow by removing the SkipSharedProject flag from the msbuild command during the build step. The goal is to ensure all projects in the solution are built, potentially resolving dependencies on shared projects. Refactor workflow upload strategy for artifacts Consolidate artifact upload steps by moving the matrix strategy under a single "Upload Artifact" step. This change simplifies the workflow by removing the commented-out and redundant sections. Add upload job to GitHub Actions workflow Renamed the build job to build-job and added a new upload-job. The upload job uses a matrix strategy to handle multiple plugins and utilizes the upload-artifact action to store build artifacts. Update artifact upload workflow Reorganized the artifact upload step to be triggered by the 'build' job. This ensures artifacts are uploaded only after the build process completes successfully. Adjusting naming conventions for better readability and maintenance. Refactor upload-artifacts workflow step Rename artifact upload step to improve clarity and consistency across the workflow file. This change aims to make the purpose of this step more explicit and easier to understand at a glance. Refactor artifact upload step in GitHub workflow Changed the artifact upload step to a reusable workflow call, increasing maintainability and consistency. This update improves the structure by aligning with the new YAML syntax for GitHub Actions workflows. Update artifact upload step in GitHub Actions workflow Changed the call-upload-artifacts-workflow step to a named step 'upload artifacts' for better clarity and consistency. This refactor ensures alignment with the naming conventions used throughout the workflow configuration. Fix workflow syntax for uploading artifacts The name of the 'call-upload-artifacts-workflow' step was removed to correct the format. This ensures that the 'uses' directive properly calls the 'upload-artifacts.yml' file, improving the workflow execution. Fix YAML syntax for upload-artifacts workflow call Enclose the workflow path in quotes to ensure proper YAML parsing. This change avoids potential syntax errors during the GitHub Actions execution. Fix incorrect path syntax in GitHub Actions workflow Corrected the path syntax in the 'call-upload-artifacts-workflow' step to ensure compatibility with GitHub Actions. This change should resolve any issues related to incorrect path references in the workflow. Fix incorrect path in GitHub Actions workflow Correct the path syntax in the 'call-upload-artifacts-workflow' step to ensure the upload-artifacts.yml workflow is properly referenced and executed. This change resolves an execution issue caused by the incorrect use of backslashes. Fix usage path in GitHub Actions workflow Changed the path specification syntax for the 'uses' directive in the main workflow to ensure consistent execution. This update replaces backslashes with single quotes to conform to YAML standards and improve reliability. Fix upload-artifacts workflow path Corrected the path for the upload-artifacts workflow in the main GitHub Actions configuration file. This change ensures that the upload-artifacts workflow is called properly during the CI process. Fix whitespace issue in main GitHub Actions workflow Corrected unnecessary whitespace in the `call-upload-artifacts-workflow` step. This change ensures cleaner and more readable YAML formatting. Fix path separator in GitHub Actions workflow Changed the path separators in the workflow file from forward slashes to backslashes. This ensures compatibility with the intended system and syntax. Fix syntax error in GitHub Actions workflow A misplaced dash was corrected in the call-upload-artifacts-workflow step, ensuring proper syntax. This change prevents potential execution errors in the CI/CD pipeline. Fix typo in GitHub Actions workflow file Corrected the syntax error from "use" to "uses" in the call-upload-artifacts-workflow step within the GitHub Actions configuration. This change ensures the upload-artifacts action is called correctly, preventing potential workflow failures. Fix workflow syntax and rename step Rename and correct the "call-upload-artifacts-workflow" step in the GitHub workflow configuration. This change ensures proper execution and visibility of the artifact upload step. Add github-actions branch to workflow triggers This update ensures that workflows are triggered on pushes to the 'github-actions' branch. It also includes minor formatting adjustments for better readability.
ivandrofly
force-pushed
the
github-actions
branch
from
b8cd8f9 to
75db412
Compare
Deleted configuration entries for project {B6BEFF13-3DDF-87D9-C875-312EA5AA33DB} that were no longer needed. This simplifies the solution file and reduces clutter.
This commit removes unnecessary PropertyGroup elements related to Debug and Release configurations from the Plugin-Shared.shproj file. This streamlines the project file by eliminating redundant configuration paths and improves maintainability.
Moved Newtonsoft.Json to the correct alphabetical position in the using directives. This change helps maintain consistency and readability in the codebase.
Reformatted the XML within the Plugin-Shared.shproj file for better readability and consistency. This includes adjusting indentation and removing unnecessary conditions for better maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the artifact upload step to be triggered by the 'build' job. This ensures artifacts are uploaded only after the build process completes successfully. Adjusting naming conventions for better readability and maintenance.
Refactor upload-artifacts workflow step
Rename artifact upload step to improve clarity and consistency across the workflow file. This change aims to make the purpose of this step more explicit and easier to understand at a glance.
Refactor artifact upload step in GitHub workflow
Changed the artifact upload step to a reusable workflow call, increasing maintainability and consistency. This update improves the structure by aligning with the new YAML syntax for GitHub Actions workflows.
Update artifact upload step in GitHub Actions workflow
Changed the call-upload-artifacts-workflow step to a named step 'upload artifacts' for better clarity and consistency. This refactor ensures alignment with the naming conventions used throughout the workflow configuration.
Fix workflow syntax for uploading artifacts
The name of the 'call-upload-artifacts-workflow' step was removed to correct the format. This ensures that the 'uses' directive properly calls the 'upload-artifacts.yml' file, improving the workflow execution.
Fix YAML syntax for upload-artifacts workflow call
Enclose the workflow path in quotes to ensure proper YAML parsing. This change avoids potential syntax errors during the GitHub Actions execution.
Fix incorrect path syntax in GitHub Actions workflow
Corrected the path syntax in the 'call-upload-artifacts-workflow' step to ensure compatibility with GitHub Actions. This change should resolve any issues related to incorrect path references in the workflow.
Fix incorrect path in GitHub Actions workflow
Correct the path syntax in the 'call-upload-artifacts-workflow' step to ensure the upload-artifacts.yml workflow is properly referenced and executed. This change resolves an execution issue caused by the incorrect use of backslashes.
Fix usage path in GitHub Actions workflow
Changed the path specification syntax for the 'uses' directive in the main workflow to ensure consistent execution. This update replaces backslashes with single quotes to conform to YAML standards and improve reliability.
Fix upload-artifacts workflow path
Corrected the path for the upload-artifacts workflow in the main GitHub Actions configuration file. This change ensures that the upload-artifacts workflow is called properly during the CI process.
Fix whitespace issue in main GitHub Actions workflow
Corrected unnecessary whitespace in the
call-upload-artifacts-workflowstep. This change ensures cleaner and more readable YAML formatting.Fix path separator in GitHub Actions workflow
Changed the path separators in the workflow file from forward slashes to backslashes. This ensures compatibility with the intended system and syntax.
Fix syntax error in GitHub Actions workflow
A misplaced dash was corrected in the call-upload-artifacts-workflow step, ensuring proper syntax. This change prevents potential execution errors in the CI/CD pipeline.
Fix typo in GitHub Actions workflow file
Corrected the syntax error from "use" to "uses" in the call-upload-artifacts-workflow step within the GitHub Actions configuration. This change ensures the upload-artifacts action is called correctly, preventing potential workflow failures.
Fix workflow syntax and rename step
Rename and correct the "call-upload-artifacts-workflow" step in the GitHub workflow configuration. This change ensures proper execution and visibility of the artifact upload step.
Add github-actions branch to workflow triggers
This update ensures that workflows are triggered on pushes to the 'github-actions' branch. It also includes minor formatting adjustments for better readability.