Properly implement ChargeAssetTXPayment and test it. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
force-pushed
the
cl/asset-tx-payment-test
branch
from
d299a88 to
fa1ca0c
Compare
clangenb
commented
Aug 31, 2024
| @@ -73,11 +74,14 @@ public async Task Extrinsic_SubmitAndWatchExtrinsicAsync() | |||
| { | |||
| var iType = new BaseVec<U8>(new U8[] { (U8)0x04, (U8)0xFF }); | |||
|
|
|||
| var assetCharge = ChargeAssetTxPayment.NewWithAsset(0, new I32(0)); | |||
There was a problem hiding this comment.
This requires that we have a liquidity pool on the chain with the asset with id 0 and our native token. On paseo we have that, and this test was run against a paseo node.
| @@ -50,7 +51,7 @@ public async Task SetupAsync() | |||
| catch (Exception ex) | |||
| { | |||
| Console.WriteLine($"Failed to connect to Substrate node: {ex.Message}"); | |||
| Assert.Ignore("Skipped test because no active Substrate node was found on 127.0.0.1:9944"); | |||
| Assert.Ignore("Skipped test because no active Substrate node was found on 127.0.0.1:9999"); | |||
There was a problem hiding this comment.
The assert message mentioned the wrong port.
clangenb
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.