Rc branch (#82)

* fixed missing comments * added comments and refactored to previous to il2cpp fix
SubstrateGaming · May 23, 2024 · bfdc2a5 · bfdc2a5
1 parent 77089e2
commit bfdc2a5
Show file tree

Hide file tree

Showing 10 changed files with 60,960 additions and 60,975 deletions.
diff --git a/Substrate.NetApi.Test/Keys/Ed25519Tests.cs b/Substrate.NetApi.Test/Keys/Ed25519Tests.cs
@@ -152,10 +152,11 @@ public async Task AccountEd25519SignatureTestComparePolkadotJsAsync(string polka
 
             Assert.IsTrue(signature1.SequenceEqual(signature2));
 
-            Assert.True(account.Verify(signature1, account.Bytes, messageBytes));
-            Assert.True(account.Verify(signature2, account.Bytes, messageBytes));
+            Assert.True(await account.VerifyAsync(signature1, account.Bytes, messageBytes));
+            Assert.True(await account.VerifyAsync(signature2, account.Bytes, messageBytes));
 
-            Assert.True(account.Verify(Utils.HexToByteArray(polkadotJsSignature), account.Bytes, messageBytes));
+            Assert.True(await account.VerifyAsync(Utils.HexToByteArray(polkadotJsSignature), account.Bytes, messageBytes));
         }
+
     }
 }
diff --git a/Substrate.NetApi/Mnemonic.cs b/Substrate.NetApi/Mnemonic.cs
@@ -162,6 +162,7 @@ public static byte[] SeedFromEntropy(byte[] entropyBytes, string password)
         /// 16, 20, 24, 28, 32 Bytes Entropy supported.
         /// </summary>
         /// <param name="entropyBytes"></param>
+        /// <param name="wordlistType"></param>
         /// <returns></returns>
         public static string[] MnemonicFromEntropy(byte[] entropyBytes, BIP39Wordlist wordlistType)
         {
@@ -218,6 +219,7 @@ public static KeyPair GetKeyPairFromMnemonic(string mnemonic, string password, B
         /// </summary>
         /// <param name="mnemonic"></param>
         /// <param name="password"></param>
+        /// <param name="keyType"></param>
         /// <param name="bIP39Wordlist"></param>
         /// <param name="expandMode"></param>
         /// <returns></returns>

diff --git a/Substrate.NetApi/Model/Rpc/StorageChangeSet.cs b/Substrate.NetApi/Model/Rpc/StorageChangeSet.cs
@@ -28,35 +28,6 @@ public override string ToString()
         }
     }
 
-    /// <summary>
-    /// TODO: This needs to be verified, if we can use it to convert straight
-    ///
-    /// pub struct StorageChangeSet<Hash> {
-    ///     pub block: Hash,
-    ///     pub changes: Vec<(StorageKey, Option<StorageData>)>,
-    /// }
-    /// </summary>
-    public class NewStorageChangeSet
-    {
-        /// <summary>
-        /// Block Hash
-        /// </summary>
-        [JsonConverter(typeof(GenericTypeConverter<Hash>))]
-        public Hash Block { get; set; }
-
-        /// <summary>
-        /// Changes
-        /// </summary>
-        [JsonConverter(typeof(GenericTypeConverter<BaseVec<BaseTuple<StorageKey, StorageData>>>))]
-        public BaseVec<BaseTuple<StorageKey, StorageData>> Changes { get; set; }
-
-        /// <inheritdoc/>
-        public override string ToString()
-        {
-            return JsonConvert.SerializeObject(this);
-        }
-    }
-
     /// <summary>
     /// Storage Key
     /// </summary>