Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

Calyx/config cache #130

Merged
merged 6 commits into from
Feb 13, 2019
Merged

Calyx/config cache #130

merged 6 commits into from
Feb 13, 2019

Conversation

pddg
Copy link
Member

@pddg pddg commented Feb 13, 2019

fix #118

以下の内容を検証するパーミッションを実装

-courses.permissions.GPARequirement

  • GPAのチェック
  • courses.permissions.ScreenNameRequirement
    • 表示名のチェック
  • courses.permissions.RankSubmitted
    • 希望提出数のチェック

それぞれ以下のエンドポイントに適用されている

  • GET `/courses/<course_pk>/
    • GPARequirement, ScreenNameRequirement
    • ユーザの情報が表示されるので希望提出数を除いたパーミッションを検証する
  • GET /courses/<course_pk>/labs/<lab_pk>/
    • GPARequirement, ScreenNameRequirement, RankSubmitted

#129 に関連してPOST /courses/<course_pk>/ranks/にもパーミッションをかけるか検討している.

@pddg pddg added the enhancement New feature or request label Feb 13, 2019
@pddg pddg added this to the FirstRelease milestone Feb 13, 2019
@pddg pddg self-assigned this Feb 13, 2019
@pddg pddg requested a review from taxio February 13, 2019 13:13
Copy link
Member

@taxio taxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pddg pddg merged commit 51f3bca into dev Feb 13, 2019
@pddg pddg deleted the calyx/config_cache branch February 13, 2019 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPAなどのユーザ属性を設定に応じて動的に返す
2 participants