Skip to content

Commit

Permalink
EC OP builtin runner (keep-starknet-strange#311)
Browse files Browse the repository at this point in the history 
* wip: deduce memory cell for EC OP

* deref const returned by switch

* add correct return

* add some tests

* add tests

* fix deduce memory cell test

* finish deduce memory cell tests

* remove unused consts and fromInteger

* replace tuple of usize with ECPoint
  • Loading branch information
@lana-shanghai
lana-shanghai authored Jan 31, 2024
1 parent a3b37c1 commit e67f6be
Show file tree
Hide file tree
Showing 4 changed files with 796 additions and 39 deletions.
28 changes: 10 additions & 18 deletions src/math/fields/elliptic_curve.zig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ pub const ECError = error{

const Felt252 = @import("./starknet.zig").Felt252;

pub const ALPHA = Felt252.one();
pub const BETA = Felt252.fromInt(u256, 3141592653589793238462643383279502884197169399375105820974944592307816406665);

/// A type that represents a point (x,y) on an elliptic curve.
pub const ECPoint = struct {
const Self = @This();
Expand Down Expand Up @@ -238,37 +241,29 @@ test "Elliptic curve math: EC add for valid pair of points C and D" {
test "Elliptic curve math: point_is_on_curve_a" {
const x = Felt252.fromInt(u256, 874739451078007766457464989774322083649278607533249481151382481072868806602);
const y = Felt252.fromInt(u256, 152666792071518830868575557812948353041420400780739481342941381225525861407);
const alpha = Felt252.one();
const beta = Felt252.fromInt(u256, 3141592653589793238462643383279502884197169399375105820974944592307816406665);
var point = ECPoint{ .x = x, .y = y };
try expect(point.pointOnCurve(alpha, beta));
try expect(point.pointOnCurve(ALPHA, BETA));
}

test "Elliptic curve math: point_is_on_curve_b" {
const x = Felt252.fromInt(u256, 3139037544796708144595053687182055617920475701120786241351436619796497072089);
const y = Felt252.fromInt(u256, 2119589567875935397690285099786081818522144748339117565577200220779667999801);
const alpha = Felt252.one();
const beta = Felt252.fromInt(u256, 3141592653589793238462643383279502884197169399375105820974944592307816406665);
var point = ECPoint{ .x = x, .y = y };
try expect(point.pointOnCurve(alpha, beta));
try expect(point.pointOnCurve(ALPHA, BETA));
}

test "Elliptic curve math: point_is_not_on_curve_a" {
const x = Felt252.fromInt(u256, 874739454078007766457464989774322083649278607533249481151382481072868806602);
const y = Felt252.fromInt(u256, 152666792071518830868575557812948353041420400780739481342941381225525861407);
const alpha = Felt252.one();
const beta = Felt252.fromInt(u256, 3141592653589793238462643383279502884197169399375105820974944592307816406665);
var point = ECPoint{ .x = x, .y = y };
try expect(!point.pointOnCurve(alpha, beta));
try expect(!point.pointOnCurve(ALPHA, BETA));
}

test "Elliptic curve math: point_is_not_on_curve_b" {
const x = Felt252.fromInt(u256, 3139037544756708144595053687182055617927475701120786241351436619796497072089);
const y = Felt252.fromInt(u256, 2119589567875935397690885099786081818522144748339117565577200220779667999801);
const alpha = Felt252.one();
const beta = Felt252.fromInt(u256, 3141592653589793238462643383279502884197169399375105820974944592307816406665);
var point = ECPoint{ .x = x, .y = y };
try expect(!point.pointOnCurve(alpha, beta));
try expect(!point.pointOnCurve(ALPHA, BETA));
}

test "Elliptic curve math: compute_ec_op_impl_valid_a" {
Expand All @@ -281,9 +276,8 @@ test "Elliptic curve math: compute_ec_op_impl_valid_a" {
.y = Felt252.fromInt(u256, 152666792071518830868575557812948353041420400780739481342941381225525861407),
};
const m = Felt252.fromInt(u8, 34);
const alpha = Felt252.one();
const height = 256;
const actual_ec_point = try ecOpImpl(partial_sum, doubled_point, m, alpha, height);
const actual_ec_point = try ecOpImpl(partial_sum, doubled_point, m, ALPHA, height);
const expected_ec_point = ECPoint{
.x = Felt252.fromInt(u256, 1977874238339000383330315148209250828062304908491266318460063803060754089297),
.y = Felt252.fromInt(u256, 2969386888251099938335087541720168257053975603483053253007176033556822156706),
Expand All @@ -302,9 +296,8 @@ test "Elliptic curve math: compute_ec_op_impl_valid_b" {
.y = Felt252.fromInt(u256, 152666792071518830868575557812948353041420400780739481342941381225525861407),
};
const m = Felt252.fromInt(u8, 34);
const alpha = Felt252.one();
const height = 256;
const actual_ec_point = try ecOpImpl(partial_sum, doubled_point, m, alpha, height);
const actual_ec_point = try ecOpImpl(partial_sum, doubled_point, m, ALPHA, height);
const expected_ec_point = ECPoint{
.x = Felt252.fromInt(u256, 2778063437308421278851140253538604815869848682781135193774472480292420096757),
.y = Felt252.fromInt(u256, 3598390311618116577316045819420613574162151407434885460365915347732568210029),
Expand All @@ -323,9 +316,8 @@ test "Elliptic curve math: compute_ec_op_invalid_same_x_coordinate" {
.y = Felt252.fromInt(u8, 12),
};
const m = Felt252.fromInt(u8, 34);
const alpha = Felt252.one();
const height = 256;
const actual_ec_point = ecOpImpl(partial_sum, doubled_point, m, alpha, height);
const actual_ec_point = ecOpImpl(partial_sum, doubled_point, m, ALPHA, height);

try expectError(ECError.XCoordinatesAreEqual, actual_ec_point);
}
6 changes: 3 additions & 3 deletions src/vm/builtins/builtin_runner/builtin_runner.zig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ pub const BuiltinRunner = union(enum) {
) !?MaybeRelocatable {
return switch (self.*) {
.Bitwise => |bitwise| try bitwise.deduceMemoryCell(address, memory),
.EcOp => |ec| ec.deduceMemoryCell(address, memory),
.EcOp => |*ec| try ec.deduceMemoryCell(allocator, address, memory),
.Hash => |*hash| try hash.deduceMemoryCell(address, memory),
.Output => |output| output.deduceMemoryCell(address, memory),
.RangeCheck => |range_check| range_check.deduceMemoryCell(address, memory),
Expand All @@ -146,8 +146,8 @@ pub const BuiltinRunner = union(enum) {
// TODO: fill-in missing builtins when implemented
return switch (self.*) {
.Bitwise => |*bitwise| bitwise.getMemorySegmentAddresses(),
.EcOp => .{ 0, 0 },
.Hash => .{ 0, 0 },
.EcOp => |*ec| ec.getMemorySegmentAddresses(),
.Hash => |*hash| hash.getMemorySegmentAddresses(),
.Output => |*output| output.getMemorySegmentAddresses(),
.RangeCheck => |*range_check| range_check.getMemorySegmentAddresses(),
.Keccak => |*keccak| keccak.getMemorySegmentAddresses(),
Expand Down
Loading

0 comments on commit e67f6be

Please sign in to comment.