Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Fix #1794 Update OpenVPN repository key #1796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thiras
Copy link
Contributor

@thiras thiras commented Jul 28, 2020

Fixes #1794

@thiras thiras marked this pull request as ready for review July 28, 2020 14:17
@thiras
Copy link
Contributor Author

thiras commented Jul 28, 2020

Fails at the checks are related to some error on util-dependency.sh. Not related to the change I've made.

@thiras
Copy link
Contributor Author

thiras commented Jul 28, 2020

@nopdotcom @jlund this is an emergency PR. OpenVPN repository key has changed as I've mentioned at #1794. Please review the PR ASAP. streisand is not working globally right now.

@noelleleigh
Copy link

noelleleigh commented Jul 29, 2020

I checked out this branch and tried installing it on Linode and got this error early in the process (reformatted for legibility):

TASK [genesis-linode : Wait until the server has finished booting and OpenSSH is accepting connections] ****************
fatal: [localhost]: FAILED! => {
  'changed': False,
  'module_stderr': '<stdin>:18: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    Traceback (most recent call last):
      File "<stdin>", line 114, in <module>
      File "<stdin>", line 106, in _ansiballz_main
      File "<stdin>", line 49, in invoke_module
      File "/usr/lib/python3.8/imp.py", line 234, in load_module
        return load_source(name, filename, file)
      File "/usr/lib/python3.8/imp.py", line 169, in load_source
        module = _exec(spec, sys.modules[name])
      File "<frozen importlib._bootstrap>", line 604, in _exec
      File "<frozen importlib._bootstrap_external>", line 783, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/tmp/ansible_wait_for_payload_j356jv4p/__main__.py", line 687, in <module>
      File "/tmp/ansible_wait_for_payload_j356jv4p/__main__.py", line 615, in main
    ConnectionResetError: [Errno 104] Connection reset by peer',
  'module_stdout': '',
  'msg': 'MODULE FAILURE\nSee stdout/stderr for the exact error',
  'rc': 1
}

PLAY RECAP *************************************************************************************************************
localhost                  : ok=4    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

@colinhc
Copy link

colinhc commented Aug 2, 2020

@thiras Thanks for the PR. Works on DO!
But I believe you will need to update this file as well
playbooks/roles/test-client/files/openvpn_signing.key

@7olstoy
Copy link

7olstoy commented Aug 11, 2020

works for me, ubuntu 16.04, hetzner cloud

@dlaweb
Copy link

dlaweb commented Aug 16, 2020

works on macos, AWS

@noorar89
Copy link

Works for me on Ubuntu LTS 20.04 and AWS, this should be merged immediately.

@patthiel
Copy link
Contributor

patthiel commented Oct 12, 2020

cc. @alimakki @CorbanR .

Edit: I'll be testing this on Linode and reporting my findings shortly.

Edit 2: checked it out and ran into #1801 .. Would be ideal if we could merge #1808 which resolves both issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URGENT Failed installation at "Add the official OpenVPN APT key"
8 participants