Created ResultLink to handle the opening of result links in new tabs #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamemakes
changed the title
|
Tested for wiki, stackoverflow & thesaurus and all looks good |
mikkeldenker
requested changes
Mar 12, 2024
| @@ -14,12 +15,12 @@ | |||
| <div class="inline-block space-x-1"> | |||
| {#each meaning.similar as similar} | |||
| <div class="float-left inline [&:not(:last-child)]:after:content-[',']"> | |||
| <a | |||
There was a problem hiding this comment.
I think this should still be a regular anchor tag as the link points to another page on stract
| {title} | ||
| use:improvements={resultIndex} | ||
| target={$resultsInNewTab ? '_blank' : null} | ||
| rel={$resultsInNewTab ? 'noopener noreferrer' : null} |
There was a problem hiding this comment.
we only need to add noopener as referrer is already handled for all links by a meta tag inside frontend/src/app.html
mikkeldenker
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174. Adds the ability of being able to open result links in a new tab. This is done via a new settings store & component to handle the logic of the store. Adds
target="_blank" rel="noopener noreferrer"to the anchor element.Screenshots
Updates to settings
The result being tested
Open in new tab disabled
Open in new tab enabled
