-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #111
Merged
Merged
Update dependencies #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oeb25
force-pushed
the
update-deps
branch
2 times, most recently
from
October 17, 2023 14:25
3b4af03
to
6ae735c
Compare
I think now that we merged your fix to Scylla driver, you don't need to use a fork, you could use our main branch, no? |
Totally @Lorak-mmk! With that, I think we are ready to merge this! |
This one required a bit of tweeking as one must now select which engine to use. Since the alice engine is used across modules, it exposes its engine, while entity index only uses its encoding internally, and thus does not re-export it.
This was a bigger one, since the API has changed a bit. For some, it has become simpler to get at the bytes, such as no longer needing to decode with a reader.
It was not used directly, but is used indirectly by tch, so there is no need to declare it explicitly.
We still need to change it to the latest crates.io version when that gets released!
Draft
mikkeldenker
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a lot of the dependencies to their latest version.
Honorable mentions are:
quick-xml
has changed its API a bit, so the way escaping and decoding works has changed.logos
no longer has#[error]
but instead the lexer returnsResult<Token, ()>
. Usages of the lexers has been updated to this new style.base64
no longer has top-levelencode
/decode
functions, as one now has to explicitly select whichEngine
to use.torch-sys
was not used directly and can be removed from the dependency list. It is, however, still in the dependency tree as a part oftch
. If this breaks something we should add it back, but no problems seem to appear.scylla
I encountered a weird issue, so we temporarily use a fork. A fix has been merged (Dereferencedatacenter
of type&&str
when comparing with&str
scylladb/scylla-rust-driver#838) so now we are waiting for a new release. For more details see Gate PartialEq and PartialOrd impls from local to foreign types behindextra_traits
rkyv/rkyv#434.I've held back on updating
safetensors
,tch
, andtokenizers
as I'm not confident in testing whether updating these cause issues or not. Other than those three crates, everything should be up-to-date!This was done as an attempt to reduce compile times, and as a huge success (/s) I can confirm that this reduces the number of LLVM lines generated by 4056, which equates to a 0.30983876% decrease!
Benchmarking incremental build times, where only
core/src/lib.rs
changes, we see little to no difference: