Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features integration joint limits #19

Open
wants to merge 108 commits into
base: master
Choose a base branch
from

Conversation

destogl
Copy link
Member

@destogl destogl commented Jul 8, 2024

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

destogl and others added 30 commits March 7, 2023 18:42
- Added initial structures for joint-limit plugins.
- Correct ruckig name and make tests to work.
- Rename the joint_limits package
- Comment and author cleanup
- Base class does not require libary.
- Delete extra layer of abstraction since not all plugins require a vector of smoothing objects.
- Restore simple_joint_limiter to a working state
- Implement init() and enforce()
- Return of joint_limits package.
- Move Ruckig limiter to package joint_limits_enforcement_plugins and make it working.
Debug and optimize Rucking JointLimiter.
…r) (#6)

* Merge error handling possilibity on read and write.

* Ros2 control extensions rolling joint limits plugins (#5)

* Added initial structures for joint-limit plugins.

* Move Ruckig limiter to package joint_limits_enforcement_plugins and make it working.

Co-authored-by: AndyZe <[email protected]>

* Add option to automatically update parameters after getting them from parameter server.

* Modify simple joint limiting plugin (same as changes to moveit2 filter)

* Add backward_ros dependency for crash stack trace

* Check for required inputs in simple joint limiter

* Change services history QOS to 'keep all' so client req are not dropped

* Add missing on 'pluginlib' dependency explicitly.

* Update ControllerParameters structure to support custom prefix and use in filters.

* Update messge.

* Change controller param changed msg log level to info instead of error

---------

Co-authored-by: Denis Štogl <[email protected]>
Co-authored-by: AndyZe <[email protected]>
Co-authored-by: bijoua <[email protected]>
Co-authored-by: bijoua29 <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Expectation changed, output is now always a valid state
including between each cmds (derivatives are valid)
mamueluth and others added 24 commits April 11, 2024 10:12
* components check for export of interfaces
* change intefaces to allow custom export and test
* Fix rst syntax and some typos

* Fix rst syntax and small typos

* Fix clang issue
@destogl destogl changed the title Dte features integration joint limits Features integration joint limits Jul 8, 2024
Copy link

mergify bot commented Jul 8, 2024

This pull request is in conflict. Could you fix it @destogl?

@destogl destogl closed this Jul 22, 2024
@destogl destogl reopened this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants