Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full variant support. not finished, showcase for what has to be changed #14

Draft
wants to merge 35 commits into
base: extend_hw_interface
Choose a base branch
from
Draft

Full variant support. not finished, showcase for what has to be changed #14

wants to merge 35 commits into from

Conversation

mamueluth
Copy link
Member

There are some open questions:

  1. Naming of WARNING_SIGNALS and WARNING_SIGNAL as well as the set/get_error_codes seems bit unintuitive any suggestions would be welcome.
  2. Should the value_ptr from handle now completely removed?
  3. How to parse the InfoDescription and initialize the value accordingly?

@mergify Mergify
Copy link

mergify bot commented Jan 24, 2024

@mamueluth, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to extend_hw_interface, but it must be in master
to have these changes reflected into new distributions.

@mamueluth mamueluth changed the title not finished, showcase for what hase to be changed Full variant support. not finished, showcase for what hase to be changed Jan 24, 2024
@mamueluth mamueluth force-pushed the extend_hw_interface branch from ee6ae9e to d7d534e Compare January 29, 2024 10:55
@mergify Mergify
Copy link

mergify bot commented Jan 29, 2024

This pull request is in conflict. Could you fix it @mamueluth?

@mamueluth mamueluth force-pushed the full_variant_support branch from 726bca7 to 1187a90 Compare January 29, 2024 12:29
@mamueluth mamueluth force-pushed the extend_hw_interface branch from 19652e8 to 0929fe9 Compare February 1, 2024 09:48
@mergify Mergify
Copy link

mergify bot commented Feb 1, 2024

This pull request is in conflict. Could you fix it @mamueluth?

@mamueluth mamueluth force-pushed the full_variant_support branch from 33dea4e to d31f042 Compare February 1, 2024 10:10
@bmagyar bmagyar mentioned this pull request Apr 1, 2024
Open
@destogl destogl changed the title Full variant support. not finished, showcase for what hase to be changed Full variant support. not finished, showcase for what has to be changed Apr 1, 2024
@mamueluth mamueluth force-pushed the extend_hw_interface branch from c27990a to ccfe700 Compare April 11, 2024 08:56
mamueluth added 19 commits April 11, 2024 14:45
@mamueluth
move creation of stateinterfaces to systeminterface
d26ea2f
@mamueluth
store description in state_interface and provide functions for
85c09e9 
setting/gettting
@mamueluth
return correct name for InterfaceDescription
afd8fae
@mamueluth
move parsing of interface description to component parser
59e9968
@mamueluth
adjusted actuator- and sensor_interface as well
49d2a60
@mamueluth
add first tests
9ea64a5
@mamueluth
adjust sensor_interface getting/setting and add tests
55952fb
@mamueluth
add more tests
db17e28
@mamueluth
first steps towards variants and storing of value in handle, missing:
2838fbb 
* variant
* adjusting of resource manager
@mamueluth
add variant support
12a910e
@mamueluth
adjusted resource manager to work with shared_ptr adapt actuator,sensor
ec7df0b 
and system
@mamueluth
cleanup
59a0f14
@mamueluth
fix failing tests
c73d9c7
@mamueluth
change rest of component_interface test and mark what should be removed
b34c09a
@mamueluth
code review suggestions and:
f4fdab7 
* components check for export of interfaces
* change intefaces to allow custom export and test
@mamueluth
undo prefix_ -> prefix (HWInfo) and Command-/StateIntefaceSharedPtr
026f43e
@mamueluth
merge parser functions
6cb2d7c
@mamueluth
export_interfaces_2() virtual for custom interface export
e0341b8
@mamueluth
use unordered map and adjust tests
c5b8db0
@mamueluth mamueluth force-pushed the full_variant_support branch from 9fbd1d6 to ad416ce Compare April 11, 2024 16:00
@mergify Mergify
Copy link

mergify bot commented Apr 11, 2024

This pull request is in conflict. Could you fix it @mamueluth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mamueluth