Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checkbox to WatermarkController to convert the pdf to pdf-image #1633

Conversation

mylk13
Copy link
Contributor

@mylk13 mylk13 commented Aug 5, 2024

Description

This change adds a checkbox (unchecked by default) to convert the pdf to pdf-image as requested here #381 (comment)
I extracted the function PdfUtils so the code can be re-used a little bit.
I am happy to receive feedback.

Closes #381

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@mylk13 mylk13 requested a review from Frooodle as a code owner August 5, 2024 14:07
@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Translation API API-related issues or pull requests labels Aug 5, 2024
@mylk13 mylk13 requested a review from Frooodle August 6, 2024 07:01
@Frooodle Frooodle enabled auto-merge (squash) August 6, 2024 08:11
@Frooodle Frooodle merged commit ec537c6 into Stirling-Tools:main Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related issues or pull requests Front End Issues or pull requests related to front-end development Java Pull requests that update Java code Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watermark Can Be Deleted, Add option to convert to image afterwards
2 participants