Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure with external forks #752

Merged

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Sep 1, 2023

This should fix the failures with the check_commit step from forks
(E.g. #737 and #739)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #752 (f7f89c0) into main (34665e2) will increase coverage by 7.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   89.72%   97.13%   +7.41%     
==========================================
  Files          42       42              
  Lines        7929     7929              
==========================================
+ Hits         7114     7702     +588     
+ Misses        815      227     -588     

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteobachetti matteobachetti added this pull request to the merge queue Sep 1, 2023
Merged via the queue into StingraySoftware:main with commit 5ecad86 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants