Print unknown reason in SMT-LIB syntax #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old format is preserved for legacy messages in the Alt-Ergo format, but the SMT-LIB format is the default one for pretty-printers, since we are moving towards preferring the SMT-LIB format. Fixes OCamlPro#966
Stevendeo
reviewed
Nov 22, 2023
src/lib/reasoners/sat_solver_sig.ml
Outdated
| | Timeout t -> Fmt.pf ppf "(:timeout %a)" pp_timeout_reason t | ||
|
|
||
| let pp_ae_unknown_reason_opt ppf = function | ||
| | None -> Fmt.pf ppf ":decided" |
There was a problem hiding this comment.
Suggested change
| | None -> Fmt.pf ppf ":decided" | |
| | None -> Fmt.pf ppf "Decided" |
src/lib/reasoners/sat_solver_sig.ml
Outdated
| @@ -35,7 +35,16 @@ type timeout_reason = | |||
| | Assume | |||
| | ProofSearch | |||
| | ModelGen | |||
| [@@deriving show] | |||
|
|
|||
| let pp_timeout_reason ppf = function | |||
There was a problem hiding this comment.
Suggested change
| let pp_timeout_reason ppf = function | |
| let pp_smt_timeout_reason ppf = function |
Stevendeo
force-pushed
the
steps-timeout
branch
from
c4b4ffb to
872f8ff
Compare
|
Closing this PR, which is now in OCamlPro#975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old format is preserved for legacy messages in the Alt-Ergo format, but the SMT-LIB format is the default one for pretty-printers, since we are moving towards preferring the SMT-LIB format.
Fixes OCamlPro#966