Keep semaphore reference in local

In case self is deinited
SteveKChiu · Oct 28, 2015 · c5e6649 · c5e6649
1 parent cac7f26
commit c5e6649
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/CoreDataMonk.podspec b/CoreDataMonk.podspec
@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
 
   s.name         = "CoreDataMonk"
-  s.version      = "0.9.6"
+  s.version      = "0.9.7"
 
   s.summary      = "A flexible and easy-to-use CoreData library for Swift"
   s.description  = <<-DESC

diff --git a/CoreDataMonk/CollectionViewDataProvider.swift b/CoreDataMonk/CollectionViewDataProvider.swift
@@ -152,7 +152,8 @@ private class CollectionViewDataBridge<EntityType: NSManagedObject>
             return
         }
 
-        dispatch_semaphore_wait(self.semaphore, dispatch_time(DISPATCH_TIME_NOW, Int64(NSEC_PER_SEC)))
+        let semaphore = self.semaphore
+        dispatch_semaphore_wait(semaphore, dispatch_time(DISPATCH_TIME_NOW, Int64(NSEC_PER_SEC)))
         self.collectionView?.performBatchUpdates({
             [weak self] in
             if let actions = self?.pendingActions where !actions.isEmpty {
@@ -167,10 +168,8 @@ private class CollectionViewDataBridge<EntityType: NSManagedObject>
             }
         }, completion: {
             [weak self] _ in
-            if let this = self {
-                this.provider?.onDataChanged?()
-                dispatch_semaphore_signal(this.semaphore)
-            }
+            self?.provider?.onDataChanged?()
+            dispatch_semaphore_signal(semaphore)
         })
     }
 }