This repository has been archived by the owner on Nov 15, 2024. It is now read-only.
Return json mimetype #428
Open
Return json mimetype #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci @PieterjanMontens ! :-) On a la tête sous l'eau en ce moment mais on reviendra à ta PR au bon moment. En te souhaitant un très bon weekend! |
|
Pas de soucis, merci |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom bleuprint route for routes returning json content, correctly setting the content-type header while being as unobtrusive as possible.
Bonjour ! J'étudiais le retour des API de la bonne boîte quand j'ai remarqué que le JSON retourné n'était pas accompagné de son entête
content-typedédiée. Je me suis donc permis de faire une suggestion (dans l'idéal, j'imagine que la "route" alternative devrait se retrouver dans un fichier librairie afin d'être réutilisable ailleurs), bien que d'autres manières de l'implémenter existent (cf. docstring)Je tente de lancer les différents tests définis dans le MakeFile pour tester la solution, mais je doute être en mesure de pouvoir reproduire l'environnement requis (les tests d'intégration semblent nécessiter l'accès à une DB). BàV, P.Montens ( https://beta.gouv.fr/startups/andi.html )