-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to fix lint #821
Merged
Merged
Trying to fix lint #821
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cb2df2c
Merge branch 'stampy-redesign' of https://github.com/StampyAI/stampy-…
bryceerobertson cf7373c
trying to fix lint
bryceerobertson 68a8ffa
still trying to fix lint
bryceerobertson d121882
fix formatting
mruwnik 642b60b
Merge branch 'stampy-redesign' into bryce-volunteer
mruwnik d7720ed
fix package-lock
mruwnik 84c0a6a
againMerge branch 'stampy-redesign' of https://github.com/StampyAI/st…
bryceerobertson 6f0b960
incorporating nemo's feedback
bryceerobertson 952e6da
fixing conflicts
bryceerobertson b5fad90
fix lint
mruwnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,12 @@ import './category-carousel.css' | |
|
||
const PER_BOX = 320 | ||
|
||
const CategoryCarousel = ({title, category}: {title: string; category: PageId}) => { | ||
interface CategoryCarouselProps { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also done |
||
title: React.ReactNode | ||
category: PageId | ||
} | ||
|
||
const CategoryCarousel = ({title, category}: CategoryCarouselProps) => { | ||
const componentRef = useRef<HTMLDivElement>(null) | ||
const [shown, setShown] = useState(0) | ||
const [offset, setOffset] = useState(0) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -843,4 +843,4 @@ button { | |
} | ||
} | ||
|
||
/* end mobile */ | ||
/* end mobile */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about just
title: ReactNode
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done