-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schema utils handling of nested arrays #5685
Conversation
27bf94e
to
6e9d0d6
Compare
3c652b5
to
0f49782
Compare
3ef0c78
to
09486a7
Compare
This test is a reproducer for #5684
09486a7
to
3413a82
Compare
09d8050
to
1d27898
Compare
I added a reproducer test for #5684 in 3413a82 which you can see failing in CI here:
Then I refactored I also left a few TODOs where I noticed some schema features like edit: well, that makes this bug fix sound more straightforward than it was. See #5684 (comment) for more on the other things I tried before coming up with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and great to have the test case so we don't suffer problem again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixed schema utils to more reliably handle schemas that define nested arrays (object-array-object-array-string) as discovered in some of the ansible installer RBAC tests. This includes a test that reproduced the error so we don't hit this again.
Closes #5684