Change BATS image

[Ein-nor]

The BATS image from Damien Duportal is no longer available in docker hub.
I have forked his repository and pushed the image to my private repository zoeleah/bats.
This is a quick fix, I think the best would be to host the image in the StackStorm Docker Hub Repository or to refactor the tests to use bats/bats.

[Ein-nor]

Updated the URL's for ST2_STREAM_URL and ST2_AUTH_URL

[arm4b]

Thanks for the contribution!
And good find it's bats that's failing 👍

Looking at the history, we had a similar PR in the K8s repo:
StackStorm/stackstorm-k8s#338
Let's rely on the official bats image so we'll be consistent with the testing approach across the projects.

Oh, and please update the https://github.com/StackStorm/st2-docker/blob/master/CHANGELOG.md as well mentioning your fixes.

[Ein-nor]

@armab
I built it a little differently, this reduced the code.
I looked at how it was set up in k8s and tried to recreate it.
But I could not get it to run. I don't think BATS is used/running in k8s.

- name: bats-core image: bats/bats:1.8.2 command: - bash - -ec - | cp -R /opt/bats /tools/
If I run this on my docker-host, I'll get this error:
root@st2-docker-test:/opt/st2-docker# docker run -v tests_tools:/tools -it --entrypoint "/bin/bash" bats/bats:1.8.2 docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/bin/bash": stat /bin/bash: no such file or directory: unknown. ERRO[0000] error waiting for container:

You have to start the container with the entrypoint /bin/ash, then it works.
root@st2-docker-test:/opt/st2-docker# docker run -v tests_tools:/tools -it --entrypoint "/bin/ash" bats/bats:1.8.2 /code # exit root@st2-docker-test:/opt/st2-docker# vi tests/st2tests.yaml

A st2test Docker container should be built so that you don't have to install bats and the helper tools at each runtime.

[arm4b]

Thanks for the fix! Installing bats via apt looks good to me.

Noticed one minor typo to fix before merging, otherwise looks good.