Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaptive version 2.0.8 #844

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Kaptive version 2.0.8 #844

merged 4 commits into from
Feb 13, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of Kaptive!

I've actually been using the image created by @kapsakcj that's been in this PR : #694 . In theory, I should just add to that PR, but there's a new version of Kaptive, so I've made a new branch and new PR.

My apologies for any confusion that may arise from this.

I made a few adjustments from @stitam and @kapsakcj 's files:

  • updated the base image to jammy (I tried to update blast, too, but that broke things)
  • added biopython version
  • changed the tests
  • moved the vibrio files

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor Author

I think this PR probably
Closes #661
Closes #694

@erinyoung erinyoung requested a review from kapsakcj January 11, 2024 22:16
@kapsakcj
Copy link
Collaborator

thanks for the PR, I will aim to get this reviewed by the end of next week. Currently in the middle of moving so time is limited

@erinyoung
Copy link
Contributor Author

@kapsakcj , when you get time, it'd be awesome if you could review this.

@kapsakcj
Copy link
Collaborator

kapsakcj commented Feb 8, 2024

thanks for the reminder, I'll take a look as soon as I have time

@kapsakcj
Copy link
Collaborator

I took a look at the GHActions workflow log here, which was triggered ~6 days ago and ran through the tests (i.e. it didn't use the cache): https://github.com/StaPH-B/docker-builds/actions/runs/7836200690/job/21383295535

everything ran as expected so I'm good to merge and deploy. I'll close PR #694

thank you for the PR and for your patience. Sorry it took me so long to review!

@kapsakcj kapsakcj merged commit a309454 into master Feb 13, 2024
2 checks passed
@kapsakcj kapsakcj deleted the erin-kaptive branch February 13, 2024 04:24
@kapsakcj
Copy link
Collaborator

deploy workflow here, it should be up on dockerhub and quay shortly: https://github.com/StaPH-B/docker-builds/actions/runs/7881702560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants