-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaptive version 2.0.8 #844
Conversation
thanks for the PR, I will aim to get this reviewed by the end of next week. Currently in the middle of moving so time is limited |
@kapsakcj , when you get time, it'd be awesome if you could review this. |
thanks for the reminder, I'll take a look as soon as I have time |
I took a look at the GHActions workflow log here, which was triggered ~6 days ago and ran through the tests (i.e. it didn't use the cache): https://github.com/StaPH-B/docker-builds/actions/runs/7836200690/job/21383295535 everything ran as expected so I'm good to merge and deploy. I'll close PR #694 thank you for the PR and for your patience. Sorry it took me so long to review! |
deploy workflow here, it should be up on dockerhub and quay shortly: https://github.com/StaPH-B/docker-builds/actions/runs/7881702560 |
There's a new version of Kaptive!
I've actually been using the image created by @kapsakcj that's been in this PR : #694 . In theory, I should just add to that PR, but there's a new version of Kaptive, so I've made a new branch and new PR.
My apologies for any confusion that may arise from this.
I made a few adjustments from @stitam and @kapsakcj 's files:
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)