Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding fasten #835

Merged
merged 1 commit into from
Jan 11, 2024
Merged

adding fasten #835

merged 1 commit into from
Jan 11, 2024

Conversation

erinyoung
Copy link
Contributor

It was the oldest issue for this repo, so I decided to make a Dockerfile for it.

Closes #201

@lskatz makes some great tools, including fasten - which is for Interleaved fastq files.

I took heavy amounts of inspiration from the Dockerfile in the fasten repo, but added some additional features to bring it into STAPH-B compliance.

Since this is a new tool, I added a new line to both the README.md and Program_Licenses.md files.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Copy link
Collaborator

@Kincekara Kincekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I am merging this.

@Kincekara Kincekara merged commit 71b0466 into master Jan 11, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for your PR!
deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/7491476439

@erinyoung erinyoung deleted the erin-fasten branch January 11, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add lskatz/fasten
2 participants