Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds el_gato #825

Merged
merged 2 commits into from
Dec 19, 2023
Merged

adds el_gato #825

merged 2 commits into from
Dec 19, 2023

Conversation

Kincekara
Copy link
Collaborator

Closes #781

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

- executable: el_gato.py
- help: -h
- version: -v
- description: Epidemiology of Legionella : Genome-bAsed Typing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self : The capital A comes from the documentation.

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no changes to recommend.

Looks great!

I'm going to

  1. merge this PR
  2. push to dockerhub and quay using both the 1.15.2 and latest tags

@erinyoung erinyoung merged commit d42e845 into StaPH-B:master Dec 19, 2023
2 checks passed
@erinyoung
Copy link
Contributor

Thank you for your contribution! You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/7265994984

@Kincekara Kincekara deleted the elgato branch December 21, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Container Request]: el_gato
2 participants