Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ppanggolin #821

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Adding ppanggolin #821

merged 3 commits into from
Dec 27, 2023

Conversation

erinyoung
Copy link
Contributor

It's not a typo.

ppanggolin is for putting together pan-genome graphs.

I originally tried to install this tool from source, but one of its dependencies (infernal) has perl has a dependency and... instead of pulling my hair out decided to use the conda installation.

The usage is a little tricky, so I encourage anyone who would like to use this to read the documentation beforehand.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor Author

Closes #754

Copy link
Collaborator

@Kincekara Kincekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Kincekara Kincekara merged commit 9bf1f9a into master Dec 27, 2023
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for your PR!
You can check the deployment from https://github.com/StaPH-B/docker-builds/actions/runs/7338931545.

@erinyoung erinyoung deleted the erin-ppanggolin branch January 4, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants