Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds isPcr #806

Merged
merged 4 commits into from
Nov 29, 2023
Merged

adds isPcr #806

merged 4 commits into from
Nov 29, 2023

Conversation

Kincekara
Copy link
Collaborator

I saw this tool as a requirement of other programs, including el_gato. Precompiled binaries do not work, and compiling it is a bit complicated. So, keeping it as a separate tool will be helpful.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor

The test looks like it worked:

#11 [test 2/2] RUN isPcr wuhCor1.fa primers stdout
#11 0.106 >NC_045512v2:10802+11390 orf1a 589bp CTAGGACCTCTTTCTGCTCA ACACTCTCCTAGCACCATCA
#11 0.106 CTAGGACCTCTTTCTGCTCAaactggaattgccgttttagatatgtgtgc
#11 0.106 ttcattaaaagaattactgcaaaatggtatgaatggacgtaccatattgg
#11 0.106 gtagtgctttattagaagatgaatttacaccttttgatgttgttagacaa
#11 0.106 tgctcaggtgttactttccaaagtgcagtgaaaagaacaatcaagggtac
#11 0.106 acaccactggttgttactcacaattttgacttcacttttagttttagtcc
#11 0.106 agagtactcaatggtctttgttcttttttttgtatgaaaatgccttttta
#11 0.106 ccttttgctatgggtattattgctatgtctgcttttgcaatgatgtttgt
#11 0.106 caaacataagcatgcatttctctgtttgtttttgttaccttctcttgcca
#11 0.106 ctgtagcttattttaatatggtctatatgcctgctagttgggtgatgcgt
#11 0.106 attatgacatggttggatatggttgatactagtttgtctggttttaagct
#11 0.106 aaaagactgtgttatgtatgcatcagctgtagtgttactaatccttatga
#11 0.106 cagcaagaactgtgtatgaTGATGGTGCTAGGAGAGTGT
#11 DONE 0.1s

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the PR.

I'm going to

  1. merge this PR
  2. deploy to dockerhub and quay using the tags '33' and 'latest'

@erinyoung erinyoung merged commit 93c3fa8 into StaPH-B:master Nov 29, 2023
2 checks passed
@Kincekara Kincekara deleted the ispcr branch November 29, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants