update freebayes1.3.7 #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! It looks like What happens if you try https://github.com/freebayes/freebayes/archive/refs/tags/v${FREEBAYES_VER}.tar.gz instead (and changing everything downstream to match)? |
|
I think I know why the *src.tar.gz file is missing : there's something wrong with the ninja tests. I've made a few changes to the Dockerfile, which you are welcome to approve or disapprove of.
|
|
@kittychaseNC , thank you for your contribution! This Dockerfile was more challenging than I was expecting (which... happens a lot in bioinformatics...). Are you okay with the changes I made? If so, I'll update https://github.com/StaPH-B/docker-builds/blob/fe4da9e6b9227801d7060500cf1394f70468a765/freebayes/1.3.7/README.md , merge this PR, and deploy to dockerhub and quay. |
|
I am absolutely OK with all those changes. Thank you so much for your help!
Kitty
Kitty Chase
Lead Bioinformatics Scientist, SaBR
NCSLPH
…________________________________
From: Young ***@***.***>
Sent: Friday, October 27, 2023 2:10:27 PM
To: StaPH-B/docker-builds ***@***.***>
Cc: Chase, Kitty ***@***.***>; Mention ***@***.***>
Subject: [External] Re: [StaPH-B/docker-builds] update freebayes1.3.7 (PR #775)
CAUTION: External email. Do not click links or open attachments unless verified. Report suspicious emails with the Report Message button located on your Outlook menu bar on the Home tab.
@kittychaseNC<https://github.com/kittychaseNC> , thank you for your contribution! This Dockerfile was more challenging than I was expecting (which... happens a lot in bioinformatics...).
Are you okay with the changes I made?
If so, I'll update https://github.com/StaPH-B/docker-builds/blob/fe4da9e6b9227801d7060500cf1394f70468a765/freebayes/1.3.7/README.md , merge this PR, and deploy to dockerhub and quay.
—
Reply to this email directly, view it on GitHub<#775 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS2PY5IUD5A3GGUM66UPUE3YBP2JHAVCNFSM6AAAAAA6RVNRGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGMYTINZRGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
________________________________
Email correspondence to and from this address is subject to the North Carolina Public Records Law and may be disclosed to third parties by an authorized State official. Unauthorized disclosure of juvenile, health, legally privileged, or otherwise confidential information, including confidential information relating to an ongoing State procurement effort, is prohibited by law. If you have received this email in error, please notify the sender immediately and delete all records of this email.
|
|
Thank you for your contribution!!! I hope you learned a lot in the Workshop! |
erinyoung
approved these changes
Oct 27, 2023
|
Yes I did thanks:)
Kitty Chase
Lead Bioinformatics Scientist, SaBR
NCSLPH
…________________________________
From: Young ***@***.***>
Sent: Friday, October 27, 2023 2:25:34 PM
To: StaPH-B/docker-builds ***@***.***>
Cc: Chase, Kitty ***@***.***>; Mention ***@***.***>
Subject: [External] Re: [StaPH-B/docker-builds] update freebayes1.3.7 (PR #775)
CAUTION: External email. Do not click links or open attachments unless verified. Report suspicious emails with the Report Message button located on your Outlook menu bar on the Home tab.
Thank you for your contribution!!!
I hope you learned a lot in the Workshop!
—
Reply to this email directly, view it on GitHub<#775 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS2PY5MZKN7W4UYAKTMLM7TYBP4B5AVCNFSM6AAAAAA6RVNRGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGMZTCOBRG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
________________________________
Email correspondence to and from this address is subject to the North Carolina Public Records Law and may be disclosed to third parties by an authorized State official. Unauthorized disclosure of juvenile, health, legally privileged, or otherwise confidential information, including confidential information relating to an ongoing State procurement effort, is prohibited by law. If you have received this email in error, please notify the sender immediately and delete all records of this email.
|
|
You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/6671135935 and it should be available on dockerhub here : https://hub.docker.com/r/staphb/freebayes/tags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15)spades/3.12.0/Dockerfile)shigatyper/2.0.1/test.sh)spades/3.12.0/README.md)