Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker workshop: Updated DNAapler to 2.0 #769

Closed
wants to merge 12 commits into from

Conversation

evagunawan
Copy link
Contributor

@evagunawan evagunawan commented Oct 24, 2023

Pull Request (PR) checklist:

  • X Include a description of what is in this pull request in this message.
  • X The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • X Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • X Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • X Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • X Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor

This looks great!

I'm going to wait to merge this until after the lecture (in case you want to change anything)

@erinyoung
Copy link
Contributor

Could you add the new version of DNAapler to the main readme?

https://github.com/evagunawan/docker-builds/edit/master/README.md

This helps people know what versions are available.

@erinyoung
Copy link
Contributor

This PR will close #715

Updated to ver 0.12.2
Updated to include dnaapler 0.2.0
Updated to include correct genotyphi and new mykrobe
Included updated mykrobe and genotyphi versions.
@evagunawan evagunawan closed this Nov 9, 2023
@erinyoung
Copy link
Contributor

@evagunawan

Oh no! I saw that you closed this PR. Is everything okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants