-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated FastANI to 1.34 #752
Conversation
Looks good! I have one requested change for fastani/1.34-RGDV2/Dockerfile in that the docker image used for the stage stage be given a tag. I am curious to what happens when --no-install-recommends is added to the apt-get statements. This generally reduces the size of the image, but sometimes it's not worth having to individually install the tools that need to get installed. |
Looks good to me! I'm going to
|
You can check the status of the deployment at |
For those who are curious, 1.33 has a compressed size of 80.45 MB. 1.34 has a compressed size of 29.08 MB. Using |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)