Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated FastANI to 1.34 #752

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

Kincekara
Copy link
Collaborator

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing
  • Updated bot FastANI and FasTANI+RGDv2 containers.
  • Used staged build for FasTANI+RGDv2
  • small modifications in dockerfile and test

@Kincekara Kincekara marked this pull request as ready for review September 7, 2023 14:01
fastani/1.34/Dockerfile Outdated Show resolved Hide resolved
@erinyoung
Copy link
Contributor

Looks good!

I have one requested change for fastani/1.34-RGDV2/Dockerfile in that the docker image used for the stage stage be given a tag.

I am curious to what happens when --no-install-recommends is added to the apt-get statements. This generally reduces the size of the image, but sometimes it's not worth having to individually install the tools that need to get installed.

@erinyoung
Copy link
Contributor

erinyoung commented Sep 15, 2023

Looks good to me! I'm going to

  1. merge this PR
  2. deploy to dockerhub and quay using the 1.34 tag and 1.34-rgdv2 for the respective files
  3. overwrite the 'latest' tag with the 1.34-rgdv2 image

@erinyoung erinyoung merged commit 0afe16f into StaPH-B:master Sep 15, 2023
3 checks passed
@erinyoung
Copy link
Contributor

You can check the status of the deployment at

@erinyoung
Copy link
Contributor

For those who are curious, 1.33 has a compressed size of 80.45 MB. 1.34 has a compressed size of 29.08 MB.

Using --no-install-recommends is very beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants