Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygenomeviz version 0.4.2 #744

Merged
merged 2 commits into from
Oct 5, 2023
Merged

pygenomeviz version 0.4.2 #744

merged 2 commits into from
Oct 5, 2023

Conversation

erinyoung
Copy link
Contributor

There's a new version of pygenomeviz, but mostly I wanted to test out a new python-centric template for simple installations with pip.

Things that are new with this version:

  • Using python:3.9.17-slim as a base instead of ubuntu:jammy
  • Added CMD layer with all of the cli options
  • Removed installation of wget, python3, and python3-pip from apt-get layer
  • Added --no-cache-dir to the pip install layer

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung erinyoung requested a review from kapsakcj September 6, 2023 20:32
@erinyoung
Copy link
Contributor Author

@kapsakcj , this Dockerfile basically uses the new python3-centric template in #501. I would LOVE for you to be really nit-picky and hyper critical of this image. Any and all comments will be used to improve the template dockerfile.

@Kincekara
Copy link
Collaborator

This looks great! @kapsakcj, I will merge and deploy the container if you don't have additional recommendations.

@kapsakcj
Copy link
Collaborator

kapsakcj commented Oct 5, 2023

Thanks for reviewing! No other comments from me. Please go ahead w merging and deploying

I am curious to see how big the docker image is once it's on dockerhub

@Kincekara Kincekara merged commit 1efaad9 into master Oct 5, 2023
@erinyoung
Copy link
Contributor Author

I would also like to know how big this image is. Turns out that matplotlib updated and broke pygenomeviz (see moshi4/pyGenomeViz#22). The newest version of pygenomeviz should have this fixed.

@erinyoung erinyoung deleted the erin-pygenomeviz-0.4.2 branch October 24, 2023 16:51
@erinyoung erinyoung restored the erin-pygenomeviz-0.4.2 branch October 24, 2023 16:52
@erinyoung erinyoung deleted the erin-pygenomeviz-0.4.2 branch October 27, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants