Optimization. Ignore empty delta updates. (#5)

Squarespace · Dec 11, 2018 · c1e7f11 · c1e7f11
1 parent 4daf229
commit c1e7f11
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/Sources/UICollectionView/CollectionViewDataSource.swift b/Sources/UICollectionView/CollectionViewDataSource.swift
@@ -21,7 +21,7 @@ open class CollectionViewDataSource<DS, VF>: NSObject, UICollectionViewDataSourc
         super.init()
 
         self.subscription = dataSource.updateHandler.subscribe { [weak self] update in
-            guard let `self` = self, !self.ignoreDataSourceUpdates else { return }
+            guard let `self` = self, !update.isEmpty, !self.ignoreDataSourceUpdates else { return }
             viewUpdate(update)
         }
     }

diff --git a/Sources/UITableView/TableViewDataSource.swift b/Sources/UITableView/TableViewDataSource.swift
@@ -21,7 +21,7 @@ open class TableViewDataSource<DS, VF>: NSObject, UITableViewDataSource where DS
         super.init()
 
         self.subscription = dataSource.updateHandler.subscribe { [weak self] update in
-            guard let `self` = self, !self.ignoreDataSourceUpdates else { return }
+            guard let `self` = self, !update.isEmpty, !self.ignoreDataSourceUpdates else { return }
             viewUpdate(update)
         }
     }

diff --git a/Sources/Updates.swift b/Sources/Updates.swift
@@ -10,6 +10,24 @@ public enum IndexedUpdate {
         deletedRows: [IndexPath]
     )
     case full
+
+    /// Whether the update is considered empty.
+    ///
+    /// - `true` for delta updates with no content
+    /// - `false` in all other cases
+    public var isEmpty: Bool {
+        switch self {
+        case let .delta(insertedSections, updatedSections, deletedSections, insertedRows, updatedRows, deletedRows):
+            return insertedSections.isEmpty &&
+                updatedSections.isEmpty &&
+                deletedSections.isEmpty &&
+                insertedRows.isEmpty &&
+                updatedRows.isEmpty &&
+                deletedRows.isEmpty
+        case .full:
+            return false
+        }
+    }
 }
 
 public class IndexedUpdateHandler {