Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to catch helm release not found errors #103

Closed
wants to merge 3 commits into from

Conversation

dalefrancum
Copy link
Contributor

@dalefrancum dalefrancum commented Oct 1, 2024

What

  • Add an extra check to see if helm will fail trying to query a release
  • It exits with a 0 so there's not a failure
  • This also removes the "Skipping"; optional, we can leave that in if desired

Why

  • We had a project failing with "release not found" errors running helm history. The idea here is to catch a helm failure and then just skip.
  • I don't think this should be permanent, just seeing if we can identify what the problems are without impacting deployments.

Testing

Test with an existing release.

❯ ./check-if-already-updated.bash restaurant-etl-dim-tax-staging restaurant-etl
***********************************
RELEASE_NAMESPACE: restaurant-etl
RELEASE_NAME: restaurant-etl-dim-tax-staging
DEPLOYMENT: restaurant-etl-dim-tax
***********************************
Needs updating.

❯ ./spoton-monochart-labels-updater.bash restaurant-etl-dim-tax-staging restaurant-etl
👷 Confirming that deployment restaurant-etl-dim-tax exists before continuing...
***********************************
RELEASE_NAMESPACE: restaurant-etl
RELEASE_NAME: restaurant-etl-dim-tax-staging
DEPLOYMENT: restaurant-etl-dim-tax
SERVICE: restaurant-etl-dim-tax
TEMP_DEPLOYMENT: restaurant-etl-dim-tax-temp
***********************************

⚠️  This was a dry run. No changes were made.

Test with a pretend release.

❯ ./check-if-already-updated.bash restaurant-etl-dim-tax-staging-foooo restaurant-etl
Error: release: not found

⚠️  Could not get status for restaurant-etl-dim-tax-staging-foooo in namespace restaurant-etl. Skipping.

❯ ./spoton-monochart-labels-updater.bash restaurant-etl-dim-tax-staging-foooo restaurant-etl
Error: release: not found

⚠️  Could not get status for restaurant-etl-dim-tax-staging-foooo in namespace restaurant-etl. Skipping.

@dalefrancum dalefrancum requested a review from a team as a code owner October 1, 2024 13:36
@dalefrancum dalefrancum closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant