Prevent precision loss when converting integer vectors to doubles

Fixes #33
SpongePowered · Aug 15, 2021 · 379366c · 379366c
1 parent 8912ded
commit 379366c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/main/template/integer/org/spongepowered/math/vector/Vector2{{E}}.java.peb b/src/main/template/integer/org/spongepowered/math/vector/Vector2{{E}}.java.peb
@@ -293,7 +293,7 @@ public final class Vector2{{ E }} implements Vector{{ E }}, Comparable<Vector2{{
 
     @Override
     public Vector2d toDouble() {
-        return new Vector2d(this.x, this.y);
+        return new Vector2d((double) this.x, (double) this.y);
     }
 
     @Override

diff --git a/src/main/template/integer/org/spongepowered/math/vector/Vector3{{E}}.java.peb b/src/main/template/integer/org/spongepowered/math/vector/Vector3{{E}}.java.peb
@@ -322,7 +322,7 @@ public final class Vector3{{ E }} implements Vector{{ E }}, Comparable<Vector3{{
 
     @Override
     public Vector3d toDouble() {
-        return new Vector3d(this.x, this.y, this.z);
+        return new Vector3d((double) this.x, (double) this.y, (double) this.z);
     }
 
     @Override

diff --git a/src/main/template/integer/org/spongepowered/math/vector/Vector4{{E}}.java.peb b/src/main/template/integer/org/spongepowered/math/vector/Vector4{{E}}.java.peb
@@ -335,7 +335,7 @@ public final class Vector4{{ E }} implements Vector{{ E }}, Comparable<Vector4{{
 
     @Override
     public Vector4d toDouble() {
-        return new Vector4d(this.x, this.y, this.z, this.w);
+        return new Vector4d((double) this.x, (double) this.y, (double) this.z, (double) this.w);
     }
 
 

diff --git a/src/test/template/integer/com/flowpowered/math/test/vector/Vector3{{E}}Test.java.peb b/src/test/template/integer/com/flowpowered/math/test/vector/Vector3{{E}}Test.java.peb
@@ -9,6 +9,7 @@ import org.spongepowered.math.test.{{ EDecEquiTest }};
 import org.spongepowered.math.test.TestUtili;
 import org.spongepowered.math.vector.Vector2{{ E }};
 import org.spongepowered.math.vector.Vector3{{ E }};
+import org.spongepowered.math.vector.Vector3d;
 import org.spongepowered.math.vector.Vector4{{ E }};
 import org.spongepowered.math.vector.VectorN{{ E }};
 
@@ -396,4 +397,9 @@ public class Vector3{{ E }}Test {
         Assertions.assertFalse(new Vector3{{ E }}(122, 43, 96).equals(new Vector3{{ E }}(378, 95, 96)));
     }
 
+    @Test
+    void testPrecisionKept() {
+        Assertions.assertEquals(new Vector3{{ E }}(29999999, 0, 0).toDouble(), new Vector3d(29999999d, 0, 0));
+    }
+
 }