Improve save_to_folder docstring
#2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
May 17, 2024
Co-authored-by: Zach McKenzie <[email protected]>
…to minor_doc_fixes
zm711
reviewed
May 17, 2024
|
Maybe based on this discussion it would be good to really try to see what the community would get the most benefit from in our docstrings. hackathon topic |
alejoe91
reviewed
May 20, 2024
alejoe91
reviewed
May 20, 2024
|
This is ready. |
alejoe91
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old one is confusing and has references to
extractor_namewhich can be confusing as some classess do have that attribute (at least for now).