Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csv write fix #1508

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Csv write fix #1508

merged 3 commits into from
Nov 18, 2024

Conversation

Christian-B
Copy link
Member

fixes a big with write csv data when recording is started after a reset.

Set write data to act like get data

  • previous segments may be empty
  • previous segments may miss some variables
  • get/write after a reset
    . fails if no previous data,
    . return previous data
    . does NOT check if all requested variables are set to record.
  • get spike counts never includes previous data so fails after a rest

fixes the test by

  • Deleting csv files from previous runs
  • Added more checks on behaviour

@Christian-B Christian-B added the blocker Do not release when one of these is open! label Nov 18, 2024
@Christian-B Christian-B merged commit c60396d into master Nov 18, 2024
13 checks passed
@Christian-B Christian-B deleted the csv_write_fix branch November 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya rowleya approved these changes

Assignees
No one assigned
Labels
blocker Do not release when one of these is open!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christian-B @rowleya