Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Br2 #70

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Br2 #70

merged 2 commits into from
Oct 6, 2022

Conversation

KingFire25
Copy link
Contributor

@KingFire25 KingFire25 commented Oct 4, 2022

Description

It is a simple GUI calculator.
Required modules tkinter , functools.

Added the files for a GUI Calculator

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation

@Aditya-150
Copy link
Collaborator

Aditya-150 commented Oct 4, 2022

#9 Issue was not supposed to be fixed.
Label not-to-be-fixed was added there. You can check.
Pls close this pr and make another.
Then it can be definitely be reviewed.

@KingFire25
Copy link
Contributor Author

#9 Issue was not supposed to be fixed. Label not-to-be-fixed was added there. You can check. Pls close this pr and make another. Then it can be definitely be reviewed.

I have removed the issue tag you can merge it now I suppose?

@Aditya-150
Copy link
Collaborator

Aditya-150 commented Oct 4, 2022

I have removed the issue tag you can merge it now I suppose?

Thanks for removing the issue tag. I just had totally forgotten about that. Thanks for reminding also. One more thing you are trying to push more than one problem solution and a project at the same time. Pls make different prs for different problems and projects. As the there are particular maintainer handling particular topic so it creates unnecessary confusion among the maintainers.

@SAP-20 Pls review this PR.

@Aditya-150
Copy link
Collaborator

Thanks for removing the issue tag. I just had totally forgotten about that. Thanks for reminding also. One more thing you are trying to push more than one problem solution and a project at the same time. Pls make different prs for different problems and projects. As the there are particular maintainer handling particular topic so it creates unnecessary confusion among the maintainers.

@SAP-20 Pls review this PR.

And sorry😅 for asking you to close the pr I shouldn't have asked that as required changes can be made in this pr.

@KingFire25
Copy link
Contributor Author

Why this branch hasn't been merged yet....Is there any problem?

@its-navneet
Copy link
Collaborator

Well done. keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants